netdev - RE: [Intel-wired-lan] [PATCH iwl-next 3/9] ice: move ice_init_interrupt_scheme() prior ice_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986497D315DAB1711099DC4E515A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Mon, 15 Sep 2025 06:31:45 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Simon Horman
	<horms@...nel.org>, "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
	"Keller, Jacob E" <jacob.e.keller@...el.com>, Jakub Kicinski
	<kuba@...nel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next 3/9] ice: move
 ice_init_interrupt_scheme() prior ice_init_pf()



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Przemek Kitszel
> Sent: Friday, September 12, 2025 3:06 PM
> To: intel-wired-lan@...ts.osuosl.org; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>
> Cc: netdev@...r.kernel.org; Simon Horman <horms@...nel.org>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>; Keller, Jacob E
> <jacob.e.keller@...el.com>; Jakub Kicinski <kuba@...nel.org>
> Subject: [Intel-wired-lan] [PATCH iwl-next 3/9] ice: move
> ice_init_interrupt_scheme() prior ice_init_pf()
> 
> Move ice_init_interrupt_scheme() prior ice_init_pf().
> To enable the move ice_set_pf_caps() was moved out from ice_init_pf()
> to the caller (ice_init_dev()), and placed prior to the irq scheme
> init.
> 
> The move makes deinit order of ice_deinit_dev() and failure-path of
> ice_init_pf() match (at least in terms of not calling
> ice_clear_interrupt_scheme() and ice_deinit_pf() in opposite ways).
> 
> The new order aligns with findings made by Jakub Buchocki in the
> commit 24b454bc354a ("ice: Fix ice module unload").
> 
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>


Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>

...