netdev - RE: [Intel-wired-lan] [PATCH iwl-next 8/9] ice: move ice_deinit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB898625D6E0E547C0F2A14D06E515A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Mon, 15 Sep 2025 06:36:43 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Simon Horman
	<horms@...nel.org>, "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
	"Keller, Jacob E" <jacob.e.keller@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next 8/9] ice: move ice_deinit_dev()
 to the end of deinit paths



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Przemek Kitszel
> Sent: Friday, September 12, 2025 3:06 PM
> To: intel-wired-lan@...ts.osuosl.org; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>
> Cc: netdev@...r.kernel.org; Simon Horman <horms@...nel.org>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>; Keller, Jacob E
> <jacob.e.keller@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next 8/9] ice: move
> ice_deinit_dev() to the end of deinit paths
> 
> ice_deinit_dev() takes care of turning off adminq processing, which is
> much needed during driver teardown (remove, reset, error path). Move
> it to the very end where applicable.
> For example, ice_deinit_hw() called after adminq deinit slows rmmod on
> my two-card setup by about 60 seconds.
> 
> ice_init_dev() and ice_deinit_dev() scopes were reduced by previous
> commits of the series, with a final touch of extracting
> ice_init_dev_hw() out now (there is no deinit counterpart).
> 
> Note that removed ice_service_task_stop() call from ice_remove() is
> placed in the ice_deinit_dev() (and stopping twice makes no sense).
> 
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> ---

...

 
>  /**
> --
> 2.39.3

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>