netdev - Re: [Intel-wired-lan] [PATCH iwl-next 1/9] ice: enforce RTNL assumption of queue NAPI manipulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29454e56-ce83-4f65-9595-28d9ac995365@intel.com>
Date: Mon, 15 Sep 2025 12:00:20 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
CC: <intel-wired-lan@...ts.osuosl.org>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, <netdev@...r.kernel.org>, Simon Horman
	<horms@...nel.org>, Jacob Keller <jacob.e.keller@...el.com>, Larysa Zaremba
	<larysa.zaremba@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next 1/9] ice: enforce RTNL
 assumption of queue NAPI manipulation

On 9/12/25 15:37, Paul Menzel wrote:
> Dear Przemek,
> 
> 
> Thank you for the patch.
> 
> Am 12.09.25 um 15:06 schrieb Przemek Kitszel:
>> Instead of making assumptions in comments move them into code.
>> Be also more precise, RTNL must be locked only when there is
>> NAPI, and we have VSIs w/o NAPI that call ice_vsi_clear_napi_queues()
>> during rmmod.
>>
>> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>> ---
>> CC:Larysa Zaremba <larysa.zaremba@...el.com>
> 
> That address is not in Cc.

meh, I guess it was thanks to missing space after a colon
Anyway, I have talked with Larysa about this in priv, no objections
reported then ;)

> 
>> ---
>>   drivers/net/ethernet/intel/ice/ice_lib.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>

Thank you

> 
> 
> Kind regards,
> 
> Paul