netdev - Re: [PATCH net-next v3 1/2] tcp: Update bind bucket state on port release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250915103904.GQ224143@horms.kernel.org>
Date: Mon, 15 Sep 2025 11:39:04 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Sitnicki <jakub@...udflare.com>
Cc: Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Kuniyuki Iwashima <kuniyu@...gle.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Paolo Abeni <pabeni@...hat.com>, kernel-team@...udflare.com,
	Lee Valentine <lvalentine@...udflare.com>
Subject: Re: [PATCH net-next v3 1/2] tcp: Update bind bucket state on port
 release

On Sat, Sep 13, 2025 at 11:04:01AM +0200, Jakub Sitnicki wrote:
> On Thu, Sep 11, 2025 at 06:06 PM -07, Jakub Kicinski wrote:
> > On Wed, 10 Sep 2025 15:08:31 +0200 Jakub Sitnicki wrote:
> >> +/**
> >> + * sk_is_connect_bind - Check if socket was auto-bound at connect() time.
> >> + * @sk: &struct inet_connection_sock or &struct inet_timewait_sock
> >> + */
> >
> > You need to document Return: value in the kdoc, annoyingly.
> > Unfortunately kdoc warnings gate running CI in netdev 'cause they
> > sometimes result in a lot of htmldocs noise :\
> 
> Ah, thanks for the hint. 'scripts/kernel-doc -v -none' didn't complain
> about it.

FWIIW, I think -Wall would cause kernel-doc to complain about this.

> 
> I think I will drop the doc comment altogether since it's just a private
> helper now and the flag it checks is properly documented.
>