netdev - [PATCH net-next v2 0/3] net: Avoid ehash lookup races

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250916064614.605075-1-xuanqiang.luo@linux.dev>
Date: Tue, 16 Sep 2025 14:46:11 +0800
From: xuanqiang.luo@...ux.dev
To: edumazet@...gle.com,
	kuniyu@...gle.com
Cc: kerneljasonxing@...il.com,
	davem@...emloft.net,
	kuba@...nel.org,
	netdev@...r.kernel.org,
	Xuanqiang Luo <luoxuanqiang@...inos.cn>
Subject: [PATCH net-next v2 0/3] net: Avoid ehash lookup races

From: Xuanqiang Luo <luoxuanqiang@...inos.cn>

After replacing R/W locks with RCU in commit 3ab5aee7fe84 ("net: Convert
TCP & DCCP hash tables to use RCU / hlist_nulls"), a race window emerged
during the switch from reqsk/sk to sk/tw.

Now that both timewait sock (tw) and full sock (sk) reside on the same
ehash chain, it is appropriate to introduce hlist_nulls replace
operations, to eliminate the race conditions caused by this window.

---
Changes:
  v2:
    * Patch 1
	* Use WRITE_ONCE() to initialize old->pprev. 
    * Patch 2&3
	* Optimize sk hashed check. Thanks Kuni for pointing it out!

  v1: https://lore.kernel.org/all/20250915070308.111816-1-xuanqiang.luo@linux.dev/

Xuanqiang Luo (3):
  rculist: Add __hlist_nulls_replace_rcu() and
    hlist_nulls_replace_init_rcu()
  inet: Avoid ehash lookup race in inet_ehash_insert()
  inet: Avoid ehash lookup race in inet_twsk_hashdance_schedule()

 include/linux/rculist_nulls.h | 61 +++++++++++++++++++++++++++++++++++
 include/net/sock.h            | 23 +++++++++++++
 net/ipv4/inet_hashtables.c    |  4 ++-
 net/ipv4/inet_timewait_sock.c | 15 ++++-----
 4 files changed, 93 insertions(+), 10 deletions(-)

-- 
2.25.1