netdev - Re: [PATCH net-next] eth: fbnic: support devmem Tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <060281aa-0511-4ebe-829e-b36301c417cd@redhat.com>
Date: Tue, 16 Sep 2025 09:26:58 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, andrew+netdev@...n.ch,
 horms@...nel.org, sdf@...ichev.me, almasrymina@...gle.com,
 alexanderduyck@...com
Subject: Re: [PATCH net-next] eth: fbnic: support devmem Tx

On 9/11/25 4:43 PM, Jakub Kicinski wrote:
> @@ -574,7 +582,11 @@ static void fbnic_clean_twq0(struct fbnic_napi_vector *nv, int napi_budget,
>  		desc_cnt--;
>  
>  		while (desc_cnt--) {
> -			fbnic_unmap_page_twd(nv->dev, &ring->desc[head]);
> +			if (ring->tx_buf[head] != FBNIC_XMIT_NOUNMAP)
> +				fbnic_unmap_page_twd(nv->dev,
> +						     &ring->desc[head]);
> +			else
> +				ring->tx_buf[head] = NULL;
>  			head++;
>  			head &= ring->size_mask;
>  		}

Why you don't need to avoid the unmap in the DMA-error path in fbnic_tx_map?

Thanks!

Paolo