netdev - Re: [PATCH net-next v2 13/14] dibs: Move data path to dibs layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e50be1a2-4e9f-44b4-b524-706be01c97e5@redhat.com>
Date: Tue, 16 Sep 2025 10:19:56 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Alexandra Winter <wintera@...ux.ibm.com>,
 "D. Wythe" <alibuda@...ux.alibaba.com>, Dust Li <dust.li@...ux.alibaba.com>,
 Sidraya Jayagond <sidraya@...ux.ibm.com>, Wenjia Zhang
 <wenjia@...ux.ibm.com>, David Miller <davem@...emloft.net>,
 Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 Andrew Lunn <andrew+netdev@...n.ch>
Cc: Julian Ruess <julianr@...ux.ibm.com>,
 Aswin Karuvally <aswin@...ux.ibm.com>, Halil Pasic <pasic@...ux.ibm.com>,
 Mahanta Jambigi <mjambigi@...ux.ibm.com>, Tony Lu
 <tonylu@...ux.alibaba.com>, Wen Gu <guwen@...ux.alibaba.com>,
 linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
 linux-s390@...r.kernel.org, Heiko Carstens <hca@...ux.ibm.com>,
 Vasily Gorbik <gor@...ux.ibm.com>, Alexander Gordeev
 <agordeev@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>,
 Sven Schnelle <svens@...ux.ibm.com>, Simon Horman <horms@...nel.org>,
 Eric Biggers <ebiggers@...nel.org>, Ard Biesheuvel <ardb@...nel.org>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 Harald Freudenberger <freude@...ux.ibm.com>,
 Konstantin Shkolnyy <kshk@...ux.ibm.com>
Subject: Re: [PATCH net-next v2 13/14] dibs: Move data path to dibs layer

On 9/11/25 9:48 PM, Alexandra Winter wrote:
> +static void __dibs_lo_unregister_dmb(struct dibs_lo_dev *ldev,
> +				     struct dibs_lo_dmb_node *dmb_node)
> +{
> +	/* remove dmb from hash table */
> +	write_lock_bh(&ldev->dmb_ht_lock);
> +	hash_del(&dmb_node->list);
> +	write_unlock_bh(&ldev->dmb_ht_lock);
> +
> +	clear_bit(dmb_node->sba_idx, ldev->sba_idx_mask);
> +	kvfree(dmb_node->cpu_addr);
> +	kfree(dmb_node);

I see the above comes directly from existing code, but it's not clear to
me where (and if) dmb_node->cpu_addr is vmalloc()ed (as opposed to
kmalloc()ed).

Could you consider switching to kfree() (if possible/applicable) and/or
add a describing comment if not?

Thanks,

Paolo