netdev - Re: [PATCH net-next 2/3] net: ipv4: simplify drop reason handling in ip_rcv_finish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xr5bpap2rxx2so5laibrpkpszdcboxqjclp3wovf347cqb4vcj@2rl5e7v2u6zv>
Date: Tue, 16 Sep 2025 10:23:11 +0200
From: Antoine Tenart <atenart@...nel.org>
To: David Ahern <dsahern@...nel.org>
Cc: Antoine Tenart <atenart@...nel.org>, davem@...emloft.net, 
	kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/3] net: ipv4: simplify drop reason handling in
 ip_rcv_finish_core

On Mon, Sep 15, 2025 at 09:49:38AM -0600, David Ahern wrote:
> On 9/15/25 3:19 AM, Antoine Tenart wrote:
> > diff --git a/net/ipv4/ip_input.c b/net/ipv4/ip_input.c
> > index 8878e865ddf6..93b8286e526a 100644
> > --- a/net/ipv4/ip_input.c
> > +++ b/net/ipv4/ip_input.c
> > @@ -335,7 +335,6 @@ static int ip_rcv_finish_core(struct net *net,
> >  			goto drop_error;
> >  	}
> >  
> > -	drop_reason = SKB_DROP_REASON_NOT_SPECIFIED;
> 
> since you are touching this function for drop reason cleanups,
> drop_reason should be changed from `int` to `enum skb_drop_reason`
> 
> >  	if (READ_ONCE(net->ipv4.sysctl_ip_early_demux) &&
> >  	    !skb_dst(skb) &&
> >  	    !skb->sk &&
> > @@ -354,7 +353,6 @@ static int ip_rcv_finish_core(struct net *net,
> >  				drop_reason = udp_v4_early_demux(skb);
> >  				if (unlikely(drop_reason))
> 
> This should be `drop_reason != SKB_NOT_DROPPED_YET`

Makes sense, will do in v2. Thanks!