netdev - RE: [PATCH net-next 2/2] ptp: rework ptp_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB851098C0A69B74DD232071B68814A@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Tue, 16 Sep 2025 09:03:17 +0000
From: Wei Fang <wei.fang@....com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
CC: Ajay Kaher <ajay.kaher@...adcom.com>, Alexey Makhalov
	<alexey.makhalov@...adcom.com>, Andrew Lunn <andrew+netdev@...n.ch>, Richard
 Cochran <richardcochran@...il.com>, Broadcom internal kernel review list
	<bcm-kernel-feedback-list@...adcom.com>, Clark Wang <xiaoning.wang@....com>,
	"David S. Miller" <davem@...emloft.net>, David Woodhouse
	<dwmw2@...radead.org>, Eric Dumazet <edumazet@...gle.com>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, Jakub Kicinski
	<kuba@...nel.org>, Jonathan Lemon <jonathan.lemon@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Nick Shi
	<nick.shi@...adcom.com>, Paolo Abeni <pabeni@...hat.com>, Sven Schnelle
	<svens@...ux.ibm.com>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Vladimir
 Oltean <vladimir.oltean@....com>, "Y.B. Lu" <yangbo.lu@....com>
Subject: RE: [PATCH net-next 2/2] ptp: rework ptp_clock_unregister() to
 disable events

> the ordering of ptp_clock_unregister() is not ideal, as the chardev
 ^
Nit: Uppercase, 't' -> 'T'

> +void ptp_disable_all_pins(struct ptp_clock *ptp)
> +{
> +	struct ptp_clock_info *info = ptp->info;
> +	unsigned int i;
> +
> +	mutex_lock(&ptp->pincfg_mux);

Currently ptp_chardev.c has been converted to use the auto-cleanup
API (scoped_cond_guard()), so scoped_guard() can be used here.

> +	for (i = 0; i < info->n_pins; i++)
> +		if (info->pin_config[i].func != PTP_PF_NONE)

It seems unnecessary to check this, since ptp_disable_pinfunc() does
nothing for PTP_PF_NONE, but of course the check can avoid meaningless
function calls. It is up to you to keep it or not.

> +			ptp_disable_pinfunc(info, info->pin_config[i].func,
> +					    info->pin_config[i].chan);
> +	mutex_unlock(&ptp->pincfg_mux);