netdev - Re: [PATCH net-next v2 1/3] net: dst_cache: implement RCU variants for dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8521a23-3b79-4946-b5e4-fb6b4963959a@redhat.com>
Date: Tue, 16 Sep 2025 11:28:12 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Marek Mietus <mmietus97@...oo.com>, netdev@...r.kernel.org,
 antonio@...nvpn.net, kuba@...nel.org
Cc: openvpn-devel@...ts.sourceforge.net
Subject: Re: [PATCH net-next v2 1/3] net: dst_cache: implement RCU variants
 for dst_cache helpers

On 9/12/25 1:24 PM, Marek Mietus wrote:
> -static struct dst_entry *dst_cache_per_cpu_get(struct dst_cache *dst_cache,
> -					       struct dst_cache_pcpu *idst)
> +static void dst_cache_per_cpu_dst_set(struct dst_cache_pcpu *dst_cache,
> +				      struct dst_entry *dst, u32 cookie)
> +{
> +	if (dst == dst_cache->dst && cookie == dst_cache->cookie)
> +		return;

The additional checks above could possibly make sense, but should never
trigger as the _set operation should follow a failing lookup.

Also are unrelated with the other changes here, they should land in a
separate patch - or be dropped.

Thanks,

Paolo