netdev - Re: [PATCH] rtnetlink: add needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <79587f3e-8f23-4a6b-af25-901364d8530d@mcwilliam.dev>
Date: Tue, 16 Sep 2025 11:56:30 +0100
From: Alasdair McWilliam <alasdair@...illiam.dev>
To: Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH] rtnetlink: add needed_{head,tail}room attributes

Hi Daniel,

On 15/09/2025 17:49, Daniel Borkmann wrote:
> Hi Alasdair,
> 

>> @@ -2243,6 +2249,8 @@ static const struct nla_policy
>> ifla_policy[IFLA_MAX+1] = {
>>       [IFLA_GSO_IPV4_MAX_SIZE]    = NLA_POLICY_MIN(NLA_U32,
>> MAX_TCP_HEADER + 1),
>>       [IFLA_GRO_IPV4_MAX_SIZE]    = { .type = NLA_U32 },
>>       [IFLA_NETNS_IMMUTABLE]    = { .type = NLA_REJECT },
>> +    [IFLA_HEADROOM]        = { .type = NLA_U16 },
>> +    [IFLA_TAILROOM]        = { .type = NLA_U16 },
> 
> Given this is for dumping only, we'd need to replace NLA_U16 above with
> NLA_REJECT
> like in case of IFLA_NETNS_IMMUTABLE.
> 
> Also the Documentation/netlink/specs/rt_link.yaml needs an extension,
> otherwise lgtm.
> $subj should have [PATCH net-next] to indicate the target tree.
> 

Acknowledged. I will revise and re-submit. I will also include
additional context in the commit log as per your later email in this thread.

> Thanks,
> Daniel

Thanks!
Alasdair