netdev - Re: [PATCH net-next v2 2/9] eth: fbnic: use fw uptime to detect fw crashes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250916123444.GA224143@horms.kernel.org>
Date: Tue, 16 Sep 2025 13:34:44 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, alexanderduyck@...com,
	jacob.e.keller@...el.com
Subject: Re: [PATCH net-next v2 2/9] eth: fbnic: use fw uptime to detect fw
 crashes

On Mon, Sep 15, 2025 at 08:53:05AM -0700, Jakub Kicinski wrote:
> Currently we only detect FW crashes when it stops responding
> to heartbeat messages. FW has a watchdog which will reset it
> in case of crashes. Use FW uptime sent in the ownership and
> heartbeat messages to detect that the watchdog has fired
> (uptime went down).
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> v2:
>  - update commit msg
>  - use uptime the entry from OWNERSHIP enum in ownership rsp parsing
>  - update comment about heartbeat rsp
> v1: https://lore.kernel.org/20250912201428.566190-3-kuba@kernel.org

Thanks for the updates.

Reviewed-by: Simon Horman <horms@...nel.org>