netdev - Re: [PATCH net-next] ppp: enable TX scatter-gather

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250916075721.273ea979@kernel.org>
Date: Tue, 16 Sep 2025 07:57:21 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Qingfang Deng <dqfext@...il.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, linux-ppp@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, Felix Fietkau <nbd@....name>
Subject: Re: [PATCH net-next] ppp: enable TX scatter-gather

On Tue, 16 Sep 2025 10:57:49 +0800 Qingfang Deng wrote:
> Hi Jakub,
> 
> On Tue, Sep 16, 2025 at 9:10 AM Jakub Kicinski <kuba@...nel.org> wrote:
> > Seems a bit racy. We can't netdev_update_features() under the spin lock
> > so there's going to be a window of time where datapath will see new
> > state but netdev flags won't be cleared, yet?
> >
> > We either need to add a explicit linearization check in the xmit path,
> > or always reset the flags to disabled before we start tweaking the
> > config and re-enable after config (tho the latter feels like a bit of
> > a hack).  
> 
> Can I modify dev->features directly under the spin lock (without
> .ndo_fix_features) ?

Hm, I'm not aware of a reason not to. You definitely need to hold
rtnl_lock, and call netdev_update_features() after.