netdev - Re: [v7, net-next 08/10] bng_en: Register rings with the firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250916155130.GK224143@horms.kernel.org>
Date: Tue, 16 Sep 2025 16:51:30 +0100
From: Simon Horman <horms@...nel.org>
To: Bhargava Marreddy <bhargava.marreddy@...adcom.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, andrew+netdev@...n.ch, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, michael.chan@...adcom.com,
	pavan.chebbi@...adcom.com, vsrama-krishna.nemani@...adcom.com,
	vikas.gupta@...adcom.com,
	Rajashekar Hudumula <rajashekar.hudumula@...adcom.com>
Subject: Re: [v7, net-next 08/10] bng_en: Register rings with the firmware

On Fri, Sep 12, 2025 at 01:05:03AM +0530, Bhargava Marreddy wrote:
> Enable ring functionality by registering RX, AGG, TX, CMPL, and
> NQ rings with the firmware. Initialise the doorbells associated
> with the rings.
> 
> Signed-off-by: Bhargava Marreddy <bhargava.marreddy@...adcom.com>
> Reviewed-by: Vikas Gupta <vikas.gupta@...adcom.com>
> Reviewed-by: Rajashekar Hudumula <rajashekar.hudumula@...adcom.com>

...

> diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_db.h b/drivers/net/ethernet/broadcom/bnge/bnge_db.h
> new file mode 100644
> index 00000000000..950ed582f1d
> --- /dev/null
> +++ b/drivers/net/ethernet/broadcom/bnge/bnge_db.h
> @@ -0,0 +1,34 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2025 Broadcom */
> +
> +#ifndef _BNGE_DB_H_
> +#define _BNGE_DB_H_
> +
> +/* 64-bit doorbell */
> +#define DBR_EPOCH_SFT					24
> +#define DBR_TOGGLE_SFT					25
> +#define DBR_XID_SFT					32
> +#define DBR_PATH_L2					(0x1ULL << 56)
> +#define DBR_VALID					(0x1ULL << 58)
> +#define DBR_TYPE_SQ					(0x0ULL << 60)
> +#define DBR_TYPE_SRQ					(0x2ULL << 60)
> +#define DBR_TYPE_CQ					(0x4ULL << 60)
> +#define DBR_TYPE_CQ_ARMALL				(0x6ULL << 60)
> +#define DBR_TYPE_NQ					(0xaULL << 60)
> +#define DBR_TYPE_NQ_ARM					(0xbULL << 60)
> +#define DBR_TYPE_NQ_MASK				(0xeULL << 60)

Perhaps BIT_ULL() and GENMASK_ULL() can be used here?

...