netdev - Re: [PATCH net-next] tools: ynl-gen: support uint in multi-attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49682000-cb30-42a5-b3ef-16d5cc1174c7@linux.dev>
Date: Tue, 16 Sep 2025 20:05:55 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 andrew+netdev@...n.ch, horms@...nel.org, donald.hunter@...il.com,
 jacob.e.keller@...el.com
Subject: Re: [PATCH net-next] tools: ynl-gen: support uint in multi-attr

On 16/09/2025 18:04, Jakub Kicinski wrote:
> The ethtool FEC histogram series run into a build issue with
> type: uint + multi-attr: True. Auto scalars use 64b types,
> we need to convert them explicitly when rendering the types.
> 
> No current spec needs this, and the ethtool FEC histogram
> doesn't need this either any more, so not posting as a fix.
> 
> Link: https://lore.kernel.org/8f52c5b8-bd8a-44b8-812c-4f30d50f63ff@redhat.com
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: donald.hunter@...il.com
> CC: jacob.e.keller@...el.com
> ---
>   tools/net/ynl/pyynl/ynl_gen_c.py | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/net/ynl/pyynl/ynl_gen_c.py b/tools/net/ynl/pyynl/ynl_gen_c.py
> index 56c63022d702..58086b101057 100755
> --- a/tools/net/ynl/pyynl/ynl_gen_c.py
> +++ b/tools/net/ynl/pyynl/ynl_gen_c.py
> @@ -720,7 +720,11 @@ from lib import SpecSubMessage
>               return 'struct ynl_string *'
>           elif self.attr['type'] in scalars:
>               scalar_pfx = '__' if ri.ku_space == 'user' else ''
> -            return scalar_pfx + self.attr['type']
> +            if self.is_auto_scalar:
> +                name = self.type[0] + '64'
> +            else:
> +                name = self.attr['type']
> +            return scalar_pfx + name
>           else:
>               raise Exception(f"Sub-type {self.attr['type']} not supported yet")
>   

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>