lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <c9533a24-a02a-4601-9b4d-197b03634c4f@gmail.com>
Date: Tue, 16 Sep 2025 22:53:26 +0300
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Shay Drori <shayd@...dia.com>,
 Mohith Kumar Thummaluru <mohith.k.kumar.thummaluru@...cle.com>,
 "saeedm@...dia.com" <saeedm@...dia.com>, "leon@...nel.org"
 <leon@...nel.org>, "tariqt@...dia.com" <tariqt@...dia.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc: "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "jacob.e.keller@...el.com" <jacob.e.keller@...el.com>,
 "elic@...dia.com" <elic@...dia.com>,
 "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 Anand Khoje <anand.a.khoje@...cle.com>,
 Manjunath Patil <manjunath.b.patil@...cle.com>,
 Rama Nichanamatlu <rama.nichanamatlu@...cle.com>,
 Rajesh Sivaramasubramaniom <rajesh.sivaramasubramaniom@...cle.com>,
 Rohit Sajan Kumar <rohit.sajan.kumar@...cle.com>,
 Moshe Shemesh <moshe@...dia.com>, Mark Bloch <mbloch@...dia.com>,
 Qing Huang <qing.huang@...cle.com>
Subject: Re: [PATCH net 1/1] net/mlx5: Clean up only new IRQ glue on
 request_irq() failure



On 16/09/2025 8:24, Shay Drori wrote:
> Hi, sorry for the late response :(
> 
> On 27/06/2025 9:50, Mohith Kumar Thummaluru wrote:
>> External email: Use caution opening links or attachments
>>
>>
..

> 
> now that the condition is only one line, you need to remove the
> parenthesis.
> 
> other than that.
> Reviewed-by: Shay Drory <shayd@...dia.com>
> 

LGTM.

Acked-by: Tariq Toukan <tariqt@...dia.com>


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ