netdev - Re: [REGRESSION] af_unix: Introduce SO_PASSRIGHTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c36676c1640cefad7f8066a98be9b9e99d233bef.camel@gmail.com>
Date: Tue, 16 Sep 2025 17:16:40 -0500
From: brian.scott.sampson@...il.com
To: Kuniyuki Iwashima <kuni1840@...il.com>, christian@...sel.eu
Cc: davem@...emloft.net, difrost.kernel@...il.com, dnaim@...hyos.org, 
	edumazet@...gle.com, horms@...nel.org, kuba@...nel.org, kuniyu@...zon.com, 
	linux-kernel@...r.kernel.org, mario.limonciello@....com,
 netdev@...r.kernel.org, 	pabeni@...hat.com, regressions@...ts.linux.dev
Subject: Re: [REGRESSION] af_unix: Introduce SO_PASSRIGHTS - break OpenGL

> Thanks for the report.
> 
> Could you test the diff below ?
> 
> look like some programs start listen()ing before setting
> SO_PASSCRED or SO_PASSPIDFD and there's a small race window.
> 
> ---8<---
> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
> index fd6b5e17f6c4..87439d7f965d 100644
> --- a/net/unix/af_unix.c
> +++ b/net/unix/af_unix.c
> @@ -1971,7 +1971,8 @@ static void unix_maybe_add_creds(struct sk_buff
> *skb, const struct sock *sk,
>  	if (UNIXCB(skb).pid)
>  		return;
>  
> -	if (unix_may_passcred(sk) || unix_may_passcred(other)) {
> +	if (unix_may_passcred(sk) || unix_may_passcred(other) ||
> +	    !other->sk_socket) {
>  		UNIXCB(skb).pid = get_pid(task_tgid(current));
>  		current_uid_gid(&UNIXCB(skb).uid, &UNIXCB(skb).gid);
>  	}
> ---8<---
Just came across this when troubleshooting a resume from suspend issue
where I'm get a black screen after suspend. Initially saw this with my
distribution's(Linux 6.16.7-2-cachyos) kernel, and confirmed the issue
in the latest version of the vanilla mainline kernel. Bisection is also
pointing to commit 3f84d577b79d2fce8221244f2509734940609ca6. 

This patch appears to be already applied in the mainline kernel, so
this might be something different. I'm new to mailing lists, so wasn't
sure if I should report this issue here or start a new email chain.

-- 
 Brian Sampson <brian.scott.sampson@...il.com>