netdev - Re: [net-next,v2] net: ravb: Fix -Wmaybe-uninitialized warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175798681799.561918.2218938223734656047.git-patchwork-notify@kernel.org>
Date: Tue, 16 Sep 2025 01:40:17 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Niklas Söderlund <niklas.soderlund+renesas@...natech.@...eaurora.org,
	se>@codeaurora.org
Cc: paul@...rker.dev, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
 przemyslaw.kitszel@...el.com
Subject: Re: [net-next,v2] net: ravb: Fix -Wmaybe-uninitialized warning

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Sat, 13 Sep 2025 15:32:29 +0200 you wrote:
> Fix a -Wmaybe-uninitialized warning by initializing the variable to
> NULL. The warning is bogus and should not happen, but fixing it allows
> running the check on the driver to catch potential future problems.
> 
>   $ make CFLAGS_ravb_main.o=-Wmaybe-uninitialized
> 
>   In function 'ravb_rx_csum_gbeth',
>       inlined from 'ravb_rx_gbeth' at .../linux/drivers/net/ethernet/renesas/ravb_main.c:923:6:
>   .../linux/drivers/net/ethernet/renesas/ravb_main.c:765:25: error: 'skb' may be used uninitialized [-Werror=maybe-uninitialized]
>     765 |         if (unlikely(skb->len < csum_len))
>         |                      ~~~^~~~~
>   .../linux/include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
>      77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
>         |                                             ^
>   .../linux/drivers/net/ethernet/renesas/ravb_main.c: In function 'ravb_rx_gbeth':
>   .../linux/drivers/net/ethernet/renesas/ravb_main.c:806:25: note: 'skb' was declared here
>     806 |         struct sk_buff *skb;
>         |                         ^~~
>   cc1: all warnings being treated as errors
> 
> [...]

Here is the summary with links:
  - [net-next,v2] net: ravb: Fix -Wmaybe-uninitialized warning
    https://git.kernel.org/netdev/net-next/c/05c05d14d95f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html