netdev - RE: [Intel-wired-lan] [PATCH iwl-net] libie: fix string names for AQ error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB89864A81AB23A4AD5A246991E517A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Wed, 17 Sep 2025 10:01:53 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Keller, Jacob E" <jacob.e.keller@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Lobakin, Aleksander"
	<aleksander.lobakin@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Michal
 Swiatkowski" <michal.swiatkowski@...ux.intel.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Keller, Jacob
 E" <jacob.e.keller@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net] libie: fix string names for AQ
 error codes



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Jacob Keller
> Sent: Tuesday, September 16, 2025 10:09 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>; Lobakin, Aleksander
> <aleksander.lobakin@...el.com>; Andrew Lunn <andrew+netdev@...n.ch>;
> David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; Michal Swiatkowski
> <michal.swiatkowski@...ux.intel.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; Keller, Jacob E <jacob.e.keller@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net] libie: fix string names for
> AQ error codes
> 
> The LIBIE_AQ_STR macro() introduced by commit 5feaa7a07b85 ("libie:
> add adminq helper for converting err to str") is used in order to
> generate strings for printing human readable error codes. Its
> definition is missing the separating underscore ('_') character which
> makes the resulting strings difficult to read. Additionally, the
> string won't match the source code, preventing search tools from
> working properly.
> 
> Add the missing underscore character, fixing the error string names.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Fixes: 5feaa7a07b85 ("libie: add adminq helper for converting err to
> str")
> ---
> I found this recently while reviewing the libie code. I believe this
> warrants a net fix because it is both simple, and because users may
> attempt to pass printed error codes into search tools like grep, and
> will be unable to locate the error values without manually adding the
> missing '_'.
> ---
>  drivers/net/ethernet/intel/libie/adminq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/libie/adminq.c
> b/drivers/net/ethernet/intel/libie/adminq.c
> index 55356548e3f0..7b4ff479e7e5 100644
> --- a/drivers/net/ethernet/intel/libie/adminq.c
> +++ b/drivers/net/ethernet/intel/libie/adminq.c
> @@ -6,7 +6,7 @@
> 
>  static const char * const libie_aq_str_arr[] = {
>  #define LIBIE_AQ_STR(x)					\
> -	[LIBIE_AQ_RC_##x]	= "LIBIE_AQ_RC" #x
> +	[LIBIE_AQ_RC_##x]	= "LIBIE_AQ_RC_" #x
>  	LIBIE_AQ_STR(OK),
>  	LIBIE_AQ_STR(EPERM),
>  	LIBIE_AQ_STR(ENOENT),
> 
> ---
> base-commit: 93ab4881a4e2b9657bdce4b8940073bfb4ed5eab
> change-id: 20250916-jk-fix-missing-underscore-e2ffc7e39438
> 
> Best regards,
> --
> Jacob Keller <jacob.e.keller@...el.com>

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>