netdev - RE: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: implement transmit hardware timestamp statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986C728A3DE354140957441E517A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Wed, 17 Sep 2025 11:21:53 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Keller, Jacob E" <jacob.e.keller@...el.com>, "Brandeburg, Jesse"
	<jbrandeburg@...udflare.com>, Jakub Kicinski <kuba@...nel.org>, "Hariprasad
 Kelam" <hkelam@...vell.com>, Simon Horman <horms@...nel.org>, Marcin Szycik
	<marcin.szycik@...ux.intel.com>, Rahul Rameshbabu <rrameshbabu@...dia.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "corbet@....net"
	<corbet@....net>, "Keller, Jacob E" <jacob.e.keller@...el.com>
CC: "Brandeburg, Jesse" <jbrandeburg@...udflare.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: implement transmit
 hardware timestamp statistics



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Jacob Keller
> Sent: Tuesday, September 16, 2025 9:15 PM
> To: Brandeburg, Jesse <jbrandeburg@...udflare.com>; Jakub Kicinski
> <kuba@...nel.org>; Hariprasad Kelam <hkelam@...vell.com>; Simon Horman
> <horms@...nel.org>; Marcin Szycik <marcin.szycik@...ux.intel.com>;
> Rahul Rameshbabu <rrameshbabu@...dia.com>; netdev@...r.kernel.org;
> intel-wired-lan@...ts.osuosl.org; linux-doc@...r.kernel.org;
> corbet@....net; Keller, Jacob E <jacob.e.keller@...el.com>
> Cc: Brandeburg, Jesse <jbrandeburg@...udflare.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: implement
> transmit hardware timestamp statistics
> 
> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
> 
> The kernel now has common statistics for transmit timestamps, so
> implement them in the ice driver.
> 
> use via
> ethtool -I -T eth0
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Jakub Kicinski <kuba@...nel.org>
> Reviewed-by: Hariprasad Kelam <hkelam@...vell.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_ethtool.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c
> b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> index 3d99c4a1e287..f8bb2d55b28c 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> @@ -4730,6 +4730,23 @@ static void ice_get_rmon_stats(struct
> net_device *netdev,
>  	*ranges = ice_rmon_ranges;
>  }
> 
> +/* ice_get_ts_stats - provide timestamping stats
> + * @netdev: the netdevice pointer from ethtool
> + * @ts_stats: the ethtool data structure to fill in  */ static void
> +ice_get_ts_stats(struct net_device *netdev,
> +			     struct ethtool_ts_stats *ts_stats) {
> +	struct ice_pf *pf = ice_netdev_to_pf(netdev);
> +	struct ice_ptp *ptp = &pf->ptp;
> +
> +	ts_stats->pkts = ptp->tx_hwtstamp_good;
> +	ts_stats->err = ptp->tx_hwtstamp_skipped +
> +			ptp->tx_hwtstamp_flushed +
> +			ptp->tx_hwtstamp_discarded;
> +	ts_stats->lost = ptp->tx_hwtstamp_timeouts; }
> +
>  #define ICE_ETHTOOL_PFR (ETH_RESET_IRQ | ETH_RESET_DMA | \
>  	ETH_RESET_FILTER | ETH_RESET_OFFLOAD)
> 
> @@ -4816,6 +4833,7 @@ static const struct ethtool_ops ice_ethtool_ops
> = {
>  	.get_eth_mac_stats	= ice_get_eth_mac_stats,
>  	.get_pause_stats	= ice_get_pause_stats,
>  	.get_rmon_stats		= ice_get_rmon_stats,
> +	.get_ts_stats		= ice_get_ts_stats,
>  	.get_drvinfo		= ice_get_drvinfo,
>  	.get_regs_len		= ice_get_regs_len,
>  	.get_regs		= ice_get_regs,
> 
> --
> 2.51.0.rc1.197.g6d975e95c9d7


Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>