netdev - RE: [Intel-wired-lan] [PATCH net-next v3 2/4] net/mlx5e: Don't query FEC statistics when FEC is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986436CA0A49118F43491A6E517A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Wed, 17 Sep 2025 11:26:43 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Jakub Kicinski
	<kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>, Michael Chan
	<michael.chan@...adcom.com>, Pavan Chebbi <pavan.chebbi@...adcom.com>, "Tariq
 Toukan" <tariqt@...dia.com>, Gal Pressman <gal@...dia.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>, Donald
 Hunter <donald.hunter@...il.com>, Carolina Jubran <cjubran@...dia.com>
CC: Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Dragos Tatulea
	<dtatulea@...dia.com>, Yael Chemla <ychemla@...dia.com>
Subject: RE: [Intel-wired-lan] [PATCH net-next v3 2/4] net/mlx5e: Don't query
 FEC statistics when FEC is disabled



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Vadim Fedorenko
> Sent: Tuesday, September 16, 2025 9:13 PM
> To: Jakub Kicinski <kuba@...nel.org>; Andrew Lunn <andrew@...n.ch>;
> Michael Chan <michael.chan@...adcom.com>; Pavan Chebbi
> <pavan.chebbi@...adcom.com>; Tariq Toukan <tariqt@...dia.com>; Gal
> Pressman <gal@...dia.com>; intel-wired-lan@...ts.osuosl.org; Donald
> Hunter <donald.hunter@...il.com>; Carolina Jubran
> <cjubran@...dia.com>; Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> Cc: Paolo Abeni <pabeni@...hat.com>; Simon Horman <horms@...nel.org>;
> netdev@...r.kernel.org; Dragos Tatulea <dtatulea@...dia.com>; Yael
> Chemla <ychemla@...dia.com>
> Subject: [Intel-wired-lan] [PATCH net-next v3 2/4] net/mlx5e: Don't
> query FEC statistics when FEC is disabled
> 
> From: Carolina Jubran <cjubran@...dia.com>
> 
> Update mlx5e_stats_fec_get() to check the active FEC mode and skip
> statistics collection when FEC is disabled.
> 
> Signed-off-by: Carolina Jubran <cjubran@...dia.com>
> Reviewed-by: Dragos Tatulea <dtatulea@...dia.com>
> Reviewed-by: Yael Chemla <ychemla@...dia.com>
> Signed-off-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
> index 87536f158d07..aae0022e8736 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
> @@ -1446,16 +1446,13 @@ static void fec_set_rs_stats(struct
> ethtool_fec_stats *fec_stats, u32 *ppcnt)  }
> 
>  static void fec_set_block_stats(struct mlx5e_priv *priv,
> +				int mode,
>  				struct ethtool_fec_stats *fec_stats)  {
>  	struct mlx5_core_dev *mdev = priv->mdev;
>  	u32 out[MLX5_ST_SZ_DW(ppcnt_reg)] = {};
>  	u32 in[MLX5_ST_SZ_DW(ppcnt_reg)] = {};
>  	int sz = MLX5_ST_SZ_BYTES(ppcnt_reg);
> -	int mode = fec_active_mode(mdev);
> -
> -	if (mode == MLX5E_FEC_NOFEC)
> -		return;
> 
>  	MLX5_SET(ppcnt_reg, in, local_port, 1);
>  	MLX5_SET(ppcnt_reg, in, grp,
> MLX5_PHYSICAL_LAYER_COUNTERS_GROUP);
> @@ -1496,11 +1493,14 @@ static void
> fec_set_corrected_bits_total(struct mlx5e_priv *priv,  void
> mlx5e_stats_fec_get(struct mlx5e_priv *priv,
>  			 struct ethtool_fec_stats *fec_stats)  {
> -	if (!MLX5_CAP_PCAM_FEATURE(priv->mdev,
> ppcnt_statistical_group))
> +	int mode = fec_active_mode(priv->mdev);
> +
> +	if (mode == MLX5E_FEC_NOFEC ||
> +	    !MLX5_CAP_PCAM_FEATURE(priv->mdev,
> ppcnt_statistical_group))
>  		return;
> 
>  	fec_set_corrected_bits_total(priv, fec_stats);
> -	fec_set_block_stats(priv, fec_stats);
> +	fec_set_block_stats(priv, mode, fec_stats);
>  }
> 
>  #define PPORT_ETH_EXT_OFF(c) \
> --
> 2.47.3

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>