netdev - Re: [PATCH iproute2-next v2] ip: iplink_bridge: Support fdb_local_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aMqi98APC2YXu5xn@shredder>
Date: Wed, 17 Sep 2025 15:00:55 +0300
From: Ido Schimmel <idosch@...dia.com>
To: Petr Machata <petrm@...dia.com>
Cc: Nikolay Aleksandrov <razor@...ckwall.org>,
	David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
	bridge@...ts.linux-foundation.org, Andy Roulin <aroulin@...dia.com>
Subject: Re: [PATCH iproute2-next v2] ip: iplink_bridge: Support
 fdb_local_vlan_0

On Tue, Sep 16, 2025 at 06:25:46PM +0200, Petr Machata wrote:
> @@ -635,6 +648,7 @@ static void bridge_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
>  
>  	if (tb[IFLA_BR_MULTI_BOOLOPT]) {
>  		__u32 mofn_bit = 1 << BR_BOOLOPT_MDB_OFFLOAD_FAIL_NOTIFICATION;
> +		__u32 fdb_vlan_0_bit = 1 << BR_BOOLOPT_FDB_LOCAL_VLAN_0;
>  		__u32 mcvl_bit = 1 << BR_BOOLOPT_MCAST_VLAN_SNOOPING;
>  		__u32 no_ll_learn_bit = 1 << BR_BOOLOPT_NO_LL_LEARN;
>  		__u32 mst_bit = 1 << BR_BOOLOPT_MST_ENABLE;
> @@ -661,6 +675,11 @@ static void bridge_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
>  				   "mdb_offload_fail_notification",
>  				   "mdb_offload_fail_notification %u ",
>  				   !!(bm->optval & mofn_bit));
> +		if (bm->optval & fdb_vlan_0_bit)

Shouldn't this be 'bm->optmask' ?

> +			print_uint(PRINT_ANY,
> +				   "fdb_local_vlan_0",
> +				   "fdb_local_vlan_0 %u ",
> +				   !!(bm->optval & fdb_vlan_0_bit));
>  	}
>  
>  	if (tb[IFLA_BR_MCAST_ROUTER])