netdev - Re: [Intel-wired-lan] [PATCH iwl-next v4 1/5] net: docs: add missing features that can have stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f80effb4-0c91-416f-a7cb-4c9a7055fa13@molgen.mpg.de>
Date: Wed, 17 Sep 2025 14:45:47 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: Jesse Brandeburg <jbrandeburg@...udflare.com>,
 Jakub Kicinski <kuba@...nel.org>, Hariprasad Kelam <hkelam@...vell.com>,
 Simon Horman <horms@...nel.org>,
 Marcin Szycik <marcin.szycik@...ux.intel.com>,
 Rahul Rameshbabu <rrameshbabu@...dia.com>, netdev@...r.kernel.org,
 intel-wired-lan@...ts.osuosl.org, linux-doc@...r.kernel.org, corbet@....net
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 1/5] net: docs: add missing
 features that can have stats

Dear Jacob, dear Jesse,


Thank you for your patch.

Am 16.09.25 um 21:14 schrieb Jacob Keller:
> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
> 
> While trying to figure out ethtool -I | --include-statistics, I noticed
> some docs got missed when implementing commit 0e9c127729be ("ethtool:
> add interface to read Tx hardware timestamping statistics").
> 
> Fix up the docs to match the kernel code, and while there, sort them in
> alphabetical order.

So, ETHTOOL_MSG_LINKSTATE_GET and ETHTOOL_MSG_TSINFO_GET were missing.

> Cc: Rahul Rameshbabu <rrameshbabu@...dia.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Rahul Rameshbabu <rrameshbabu@...dia.com>
> Reviewed-by: Jakub Kicinski <kuba@...nel.org>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> ---
>   Documentation/networking/statistics.rst | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/networking/statistics.rst b/Documentation/networking/statistics.rst
> index 518284e287b0..66b0ef941457 100644
> --- a/Documentation/networking/statistics.rst
> +++ b/Documentation/networking/statistics.rst
> @@ -184,9 +184,11 @@ Protocol-related statistics can be requested in get commands by setting
>   the `ETHTOOL_FLAG_STATS` flag in `ETHTOOL_A_HEADER_FLAGS`. Currently
>   statistics are supported in the following commands:
>   
> -  - `ETHTOOL_MSG_PAUSE_GET`
>     - `ETHTOOL_MSG_FEC_GET`
> +  - `ETHTOOL_MSG_LINKSTATE_GET`
>     - `ETHTOOL_MSG_MM_GET`
> +  - `ETHTOOL_MSG_PAUSE_GET`
> +  - `ETHTOOL_MSG_TSINFO_GET`
>   
>   debugfs
>   -------
> 

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul