netdev - Re: [PATCH net-next V2 02/10] net/mlx5: Remove unused 'offset' field from mlx5_sq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250917125325.GC394836@horms.kernel.org>
Date: Wed, 17 Sep 2025 13:53:25 +0100
From: Simon Horman <horms@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Jiri Pirko <jiri@...nulli.us>, Jonathan Corbet <corbet@....net>,
	Leon Romanovsky <leon@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>,
	Saeed Mahameed <saeedm@...dia.com>, Mark Bloch <mbloch@...dia.com>,
	Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Jesper Dangaard Brouer <hawk@...nel.org>,
	John Fastabend <john.fastabend@...il.com>, netdev@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-rdma@...r.kernel.org, bpf@...r.kernel.org,
	Gal Pressman <gal@...dia.com>, Cosmin Ratiu <cratiu@...dia.com>,
	Dragos Tatulea <dtatulea@...dia.com>, Jiri Pirko <jiri@...dia.com>,
	Jason Gunthorpe <jgg@...dia.com>
Subject: Re: [PATCH net-next V2 02/10] net/mlx5: Remove unused 'offset' field
 from mlx5_sq_bfreg

On Tue, Sep 16, 2025 at 05:11:36PM +0300, Tariq Toukan wrote:
> From: Cosmin Ratiu <cratiu@...dia.com>
> 
> The 'offset' field was introduced in the original commit [1] and never
> used until commit [2], which added an unnecessary use.
> 
> Remove the field and refactor the write-combining test to use a local
> variable instead.
> 
> [1] commit a6d51b68611e ("net/mlx5: Introduce blue flame register
> allocator")
> [2] commit d98995b4bf98 ("net/mlx5: Reimplement write combining test")
> Signed-off-by: Cosmin Ratiu <cratiu@...dia.com>
> Reviewed-by: Dragos Tatulea <dtatulea@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>