netdev - Re: [PATCH net-next v3 1/3] net: stmmac: enhance VLAN protocol detection for GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250917145443.GN394836@horms.kernel.org>
Date: Wed, 17 Sep 2025 15:54:43 +0100
From: Simon Horman <horms@...nel.org>
To: Konrad Leszczynski <konrad.leszczynski@...el.com>
Cc: davem@...emloft.net, andrew+netdev@...n.ch, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, cezary.rojewski@...el.com,
	sebastian.basierski@...el.com,
	Piotr Warpechowski <piotr.warpechowski@...el.com>,
	Karol Jurczenia <karol.jurczenia@...el.com>
Subject: Re: [PATCH net-next v3 1/3] net: stmmac: enhance VLAN protocol
 detection for GRO

On Tue, Sep 16, 2025 at 02:48:06PM +0200, Konrad Leszczynski wrote:
> From: Piotr Warpechowski <piotr.warpechowski@...el.com>
> 
> Enhance protocol extraction in stmmac_has_ip_ethertype() by introducing
> MAC offset parameter and changing:
> 
> __vlan_get_protocol() ->  __vlan_get_protocol_offset()
> 
> Add correct header length for VLAN tags, which enable Generic Receive
> Offload (GRO) in VLAN.
> 
> Co-developed-by: Karol Jurczenia <karol.jurczenia@...el.com>
> Signed-off-by: Karol Jurczenia <karol.jurczenia@...el.com>
> Reviewed-by: Konrad Leszczynski <konrad.leszczynski@...el.com>
> Reviewed-by: Sebastian Basierski <sebastian.basierski@...el.com>
> Reviewed-by: Cezary Rojewski <cezary.rojewski@...el.com>
> Signed-off-by: Piotr Warpechowski <piotr.warpechowski@...el.com>

Hi Konrad,

As you are sending these patches, your Signed-off-by line is needed.
I would suggest at the end of the tags. And when present,
you can drop your Reviewed-by tag (it is implied).

Otherwise this patch looks good to me.

Same for the other patches in this series.

-- 
pw-bot: changes-requested