netdev - Re: [PATCH net] net: clear sk->sk_ino in sk_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEWA0a7fnv3hRJyYGkP9yjcG-dAGFbb0JjdmTF3a5kk6n3RAOg@mail.gmail.com>
Date: Wed, 17 Sep 2025 10:28:48 -0700
From: Andrei Vagin <avagin@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com, stable <stable@...r.kernel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH net] net: clear sk->sk_ino in sk_set_socket(sk, NULL)

On Wed, Sep 17, 2025 at 10:20 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Wed, Sep 17, 2025 at 10:03 AM Andrei Vagin <avagin@...gle.com> wrote:
> >
> >  is
> >
> > On Wed, Sep 17, 2025 at 8:59 AM Eric Dumazet <edumazet@...gle.com> wrote:
> > >
> > > On Wed, Sep 17, 2025 at 8:39 AM Andrei Vagin <avagin@...gle.com> wrote:
> > > >
> > > > On Wed, Sep 17, 2025 at 6:53 AM Eric Dumazet <edumazet@...gle.com> wrote:
> > > > >
> > > > > Andrei Vagin reported that blamed commit broke CRIU.
> > > > >
> > > > > Indeed, while we want to keep sk_uid unchanged when a socket
> > > > > is cloned, we want to clear sk->sk_ino.
> > > > >
> > > > > Otherwise, sock_diag might report multiple sockets sharing
> > > > > the same inode number.
> > > > >
> > > > > Move the clearing part from sock_orphan() to sk_set_socket(sk, NULL),
> > > > > called both from sock_orphan() and sk_clone_lock().
> > > > >
> > > > > Fixes: 5d6b58c932ec ("net: lockless sock_i_ino()")
> > > > > Closes: https://lore.kernel.org/netdev/aMhX-VnXkYDpKd9V@google.com/
> > > > > Closes: https://github.com/checkpoint-restore/criu/issues/2744
> > > > > Reported-by: Andrei Vagin <avagin@...gle.com>
> > > > > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> > > >
> > > > Acked-by: Andrei Vagin <avagin@...gle.com>
> > > > I think we need to add `Cc: stable@...r.kernel.org`.
> > >
> > > I never do this. Note that the prior patch had no such CC.
> >
> > The original patch has been ported to the v6.16 kernels. According to the
> > kernel documentation
> > (https://www.kernel.org/doc/html/v6.5/process/stable-kernel-rules.html),
> > adding Cc: stable@...r.kernel.org is required for automatic porting into
> > stable trees. Without this tag, someone will likely need to manually request
> > that this patch be ported. This is my understanding of how the stable
> > branch process works, sorry if I missed something.
>
> Andrei, I think I know pretty well what I am doing. You do not have to
> explain to me anything.


Eric, please don't misunderstand me. I want to get this patch into the stable
kernels as soon as possible. I appreciate your help here.

Thanks again for the fix.