[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250917184053.GV394836@horms.kernel.org>
Date: Wed, 17 Sep 2025 19:40:53 +0100
From: Simon Horman <horms@...nel.org>
To: Bobby Eshleman <bobbyeshleman@...il.com>
Cc: Stefano Garzarella <sgarzare@...hat.com>, Shuah Khan <shuah@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Stefan Hajnoczi <stefanha@...hat.com>,
"Michael S. Tsirkin" <mst@...hat.com>,
Jason Wang <jasowang@...hat.com>,
Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
Eugenio Pérez <eperezma@...hat.com>,
"K. Y. Srinivasan" <kys@...rosoft.com>,
Haiyang Zhang <haiyangz@...rosoft.com>,
Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
Bryan Tan <bryan-bt.tan@...adcom.com>,
Vishnu Dasa <vishnu.dasa@...adcom.com>,
Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
virtualization@...ts.linux.dev, netdev@...r.kernel.org,
linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
kvm@...r.kernel.org, linux-hyperv@...r.kernel.org,
berrange@...hat.com, Bobby Eshleman <bobbyeshleman@...a.com>
Subject: Re: [PATCH net-next v6 0/9] vsock: add namespace support to
vhost-vsock
On Wed, Sep 17, 2025 at 09:33:41AM -0700, Bobby Eshleman wrote:
> On Wed, Sep 17, 2025 at 05:19:28PM +0100, Simon Horman wrote:
> > On Tue, Sep 16, 2025 at 04:43:44PM -0700, Bobby Eshleman wrote:
> >
> > ...
> >
> > > base-commit: 949ddfb774fe527cebfa3f769804344940f7ed2e
> >
> > Hi Bobby,
> >
> > This series does not seem to compile when applied to the commit above.
> > Likewise when applied to current net-next (which is now slightly newer).
> >
> > hyperv_transport.c: In function ‘hvs_open_connection’:
> > hyperv_transport.c:316:14: error: too few arguments to function ‘vsock_find_bound_socket’
> > 316 | sk = vsock_find_bound_socket(&addr, vsock_global_dummy_net());
> > | ^~~~~~~~~~~~~~~~~~~~~~~
> > In file included from hyperv_transport.c:15:
> > /home/horms/projects/linux/linux/include/net/af_vsock.h:218:14: note: declared here
> > 218 | struct sock *vsock_find_bound_socket(struct sockaddr_vm *addr, struct net *net,
> > | ^~~~~~~~~~~~~~~~~~~~~~~
> >
> > --
> > pw-bot: changes-requested
>
> Ah dang it, looks like I had hvc disabled when I build tested it.
>
> Thanks for the catch, I'll fix this in the next rev.
Thanks, that would explain things.
Stuff happens :)
Powered by blists - more mailing lists