netdev - Re: [PATCH iproute2-next v5 1/1] iproute: Extend bonding's "arp_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250917120026.7601b13a@hermes.local>
Date: Wed, 17 Sep 2025 12:00:26 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: David Wilder <wilder@...ibm.com>
Cc: netdev@...r.kernel.org, jv@...sburgh.net, pradeeps@...ux.vnet.ibm.com,
 pradeep@...ibm.com, i.maximets@....org, amorenoz@...hat.com,
 haliu@...hat.com, dsahern@...il.com
Subject: Re: [PATCH iproute2-next v5 1/1] iproute: Extend bonding's
 "arp_ip_target" parameter to add vlan tags.

On Tue,  2 Sep 2025 14:15:52 -0700
David Wilder <wilder@...ibm.com> wrote:

>  				for (i = 0; target && i < BOND_MAX_ARP_TARGETS; i++) {
> -					__u32 addr = get_addr32(target);
> +					struct __attribute__((packed)) Data {
> +						__u32 addr;
> +						struct bond_vlan_tag vlans[];
> +					} data;

Do not add unnecessary packed attribute. The compiler won't pad.
Do not use Capitalization on structure types.
You can just use:
					struct {