netdev - Re: [PATCH net-next] net: phy: micrel: Add Fast link failure support for lan8842

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250917070516.a5pykok2e6xfjyao@DEN-DL-M31836.microchip.com>
Date: Wed, 17 Sep 2025 09:05:16 +0200
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <hkallweit1@...il.com>, <linux@...linux.org.uk>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: phy: micrel: Add Fast link failure support
 for lan8842

The 09/16/2025 14:53, Andrew Lunn wrote:
> 
> On Tue, Sep 16, 2025 at 09:34:27AM +0200, Horatiu Vultur wrote:
> > The 09/15/2025 14:42, Andrew Lunn wrote:
> >
> > Hi Andrew,
> >
> > >
> > > > +/**
> > > > + * LAN8814_PAGE_PCS - Selects Extended Page 0.
> > > > + *
> > > > + * This page appaers to control the fast link failure and there are different
> 
> > And the reason why I say it 'appears' is because I have seen most of the
> > registers are for debug and some timers.
> 
> So maybe change the comment to
> 
>         This page contains timers and debug registers...
> 
> It does not matter if the document is public or not, the description
> is then correct and does not give the suggestion it is guesswork.

Yes, I will change this in the next version.

> 
>         Andrew

-- 
/Horatiu