Message-ID: <e05f2321-9246-466f-a577-6d0b83beaa89@redhat.com>
Date: Thu, 18 Sep 2025 13:35:54 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Eric Dumazet <edumazet@...gle.com>, patchwork-bot+netdevbpf@...nel.org
Cc: Daniel Zahka <daniel.zahka@...il.com>, donald.hunter@...il.com,
 kuba@...nel.org, davem@...emloft.net, horms@...nel.org, corbet@....net,
 andrew+netdev@...n.ch, saeedm@...dia.com, leon@...nel.org,
 tariqt@...dia.com, borisp@...dia.com, kuniyu@...gle.com, willemb@...gle.com,
 dsahern@...nel.org, ncardwell@...gle.com, phaddad@...dia.com,
 raeds@...dia.com, jianbol@...dia.com, dtatulea@...dia.com,
 rrameshbabu@...dia.com, sdf@...ichev.me, toke@...hat.com,
 aleksander.lobakin@...el.com, kiran.kella@...adcom.com,
 jacob.e.keller@...el.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v13 00/19] add basic PSP encryption for TCP
 connections

On 9/18/25 1:27 PM, Eric Dumazet wrote:
> On Thu, Sep 18, 2025 at 4:24 AM Eric Dumazet <edumazet@...gle.com> wrote:
>> On Thu, Sep 18, 2025 at 4:02 AM Eric Dumazet <edumazet@...gle.com> wrote:
>>> On Thu, Sep 18, 2025 at 4:00 AM Eric Dumazet <edumazet@...gle.com> wrote:
>>>> On Thu, Sep 18, 2025 at 3:50 AM <patchwork-bot+netdevbpf@...nel.org> wrote:
>>>>>
>>>>> Hello:
>>>>>
>>>>> This series was applied to netdev/net-next.git (main)
>>>>> by Paolo Abeni <pabeni@...hat.com>:
>>>>>
>>>>> On Tue, 16 Sep 2025 17:09:27 -0700 you wrote:
>>>>>> This is v13 of the PSP RFC [1] posted by Jakub Kicinski one year
>>>>>> ago. General developments since v1 include a fork of packetdrill [2]
>>>>>> with support for PSP added, as well as some test cases, and an
>>>>>> implementation of PSP key exchange and connection upgrade [3]
>>>>>> integrated into the fbthrift RPC library. Both [2] and [3] have been
>>>>>> tested on server platforms with PSP-capable CX7 NICs. Below is the
>>>>>> cover letter from the original RFC:
>>>>>>
>>>>>> [...]
>>>>>
>>>>> Here is the summary with links:
>>>>>   - [net-next,v13,01/19] psp: add documentation
>>>>>     https://git.kernel.org/netdev/net-next/c/a9266275fd7b
>>>>>   - [net-next,v13,02/19] psp: base PSP device support
>>>>>     https://git.kernel.org/netdev/net-next/c/00c94ca2b99e
>>>>>   - [net-next,v13,03/19] net: modify core data structures for PSP datapath support
>>>>>     https://git.kernel.org/netdev/net-next/c/ed8a507b7483
>>>>>   - [net-next,v13,04/19] tcp: add datapath logic for PSP with inline key exchange
>>>>>     https://git.kernel.org/netdev/net-next/c/659a2899a57d
>>>>>   - [net-next,v13,05/19] psp: add op for rotation of device key
>>>>>     https://git.kernel.org/netdev/net-next/c/117f02a49b77
>>>>>   - [net-next,v13,06/19] net: move sk_validate_xmit_skb() to net/core/dev.c
>>>>>     https://git.kernel.org/netdev/net-next/c/8c511c1df380
>>>>>   - [net-next,v13,07/19] net: tcp: allow tcp_timewait_sock to validate skbs before handing to device
>>>>>     https://git.kernel.org/netdev/net-next/c/0917bb139eed
>>>>>   - [net-next,v13,08/19] net: psp: add socket security association code
>>>>>     https://git.kernel.org/netdev/net-next/c/6b46ca260e22
>>>>>   - [net-next,v13,09/19] net: psp: update the TCP MSS to reflect PSP packet overhead
>>>>>     https://git.kernel.org/netdev/net-next/c/e97269257fe4
>>>>>   - [net-next,v13,10/19] psp: track generations of device key
>>>>>     https://git.kernel.org/netdev/net-next/c/e78851058b35
>>>>>   - [net-next,v13,11/19] net/mlx5e: Support PSP offload functionality
>>>>>     https://git.kernel.org/netdev/net-next/c/89ee2d92f66c
>>>>>   - [net-next,v13,12/19] net/mlx5e: Implement PSP operations .assoc_add and .assoc_del
>>>>>     https://git.kernel.org/netdev/net-next/c/af2196f49480
>>>>>   - [net-next,v13,13/19] psp: provide encapsulation helper for drivers
>>>>>     https://git.kernel.org/netdev/net-next/c/fc724515741a
>>>>>   - [net-next,v13,14/19] net/mlx5e: Implement PSP Tx data path
>>>>>     https://git.kernel.org/netdev/net-next/c/e5a1861a298e
>>>>>   - [net-next,v13,15/19] net/mlx5e: Add PSP steering in local NIC RX
>>>>>     https://git.kernel.org/netdev/net-next/c/9536fbe10c9d
>>>>>   - [net-next,v13,16/19] net/mlx5e: Configure PSP Rx flow steering rules
>>>>>     https://git.kernel.org/netdev/net-next/c/2b6e450bfde7
>>>>>   - [net-next,v13,17/19] psp: provide decapsulation and receive helper for drivers
>>>>>     https://git.kernel.org/netdev/net-next/c/0eddb8023cee
>>>>>   - [net-next,v13,18/19] net/mlx5e: Add Rx data path offload
>>>>>     https://git.kernel.org/netdev/net-next/c/29d7f433fcec
>>>>>   - [net-next,v13,19/19] net/mlx5e: Implement PSP key_rotate operation
>>>>>     https://git.kernel.org/netdev/net-next/c/411d9d33c8a2
>>>>>
>>>>> You are awesome, thank you!
>>>>> --
>>>>> Deet-doot-dot, I am a bot.
>>>>> https://korg.docs.kernel.org/patchwork/pwbot.html
>>>>
>>>> I just saw a name conflict on psp_dev_destroy(), not sure why it was
>>>> not caught earlier.
>>>>
>>>> drivers/crypto/ccp/psp-dev.c:294:void psp_dev_destroy(struct sp_device *sp)
>>>> drivers/crypto/ccp/sp-dev.c:210:                psp_dev_destroy(sp);
>>>> drivers/crypto/ccp/sp-dev.h:175:void psp_dev_destroy(struct sp_device *sp);
>>>> drivers/crypto/ccp/sp-dev.h:182:static inline void
>>>> psp_dev_destroy(struct sp_device *sp) { }
>>>> net/psp/psp.h:16:void psp_dev_destroy(struct psp_dev *psd);
>>>> net/psp/psp.h:45:               psp_dev_destroy(psd);
>>>> net/psp/psp_main.c:102:void psp_dev_destroy(struct psp_dev *psd)
>>>> net/psp/psp_main.c:125: /* Wait until psp_dev_destroy() to call
>>>> xa_erase() to prevent a
>>>
>>> Indeed :
>>>
>>> ld: net/psp/psp_main.o: in function `psp_dev_destroy':
>>> git/net-next/net/psp/psp_main.c:103: multiple definition of
>>> `psp_dev_destroy';
>>> drivers/crypto/ccp/psp-dev.o:git/net-next/drivers/crypto/ccp/psp-dev.c:295:
>>> first defined here
>>
>> I will rename our psp_dev_destroy to psp_netdev_destroy.
> 
> Or keep psp_dev prefix.  I will use psp_dev_free()

FWIW, I think the latter option would be better.

/P

Powered by blists - more mailing lists