netdev - Re: [PATCH net-next v13 01/19] psp: add documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+FeSDiRkE7ZXZGJ2bTwYX0=745sPkkvr67x0rqW=fM5Q@mail.gmail.com>
Date: Wed, 17 Sep 2025 20:26:27 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Daniel Zahka <daniel.zahka@...il.com>
Cc: Donald Hunter <donald.hunter@...il.com>, Jakub Kicinski <kuba@...nel.org>, 
	"David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Jonathan Corbet <corbet@....net>, Andrew Lunn <andrew+netdev@...n.ch>, 
	Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>, Tariq Toukan <tariqt@...dia.com>, 
	Boris Pismenny <borisp@...dia.com>, Kuniyuki Iwashima <kuniyu@...gle.com>, 
	Willem de Bruijn <willemb@...gle.com>, David Ahern <dsahern@...nel.org>, 
	Neal Cardwell <ncardwell@...gle.com>, Patrisious Haddad <phaddad@...dia.com>, Raed Salem <raeds@...dia.com>, 
	Jianbo Liu <jianbol@...dia.com>, Dragos Tatulea <dtatulea@...dia.com>, 
	Rahul Rameshbabu <rrameshbabu@...dia.com>, Stanislav Fomichev <sdf@...ichev.me>, 
	Toke Høiland-Jørgensen <toke@...hat.com>, 
	Alexander Lobakin <aleksander.lobakin@...el.com>, Kiran Kella <kiran.kella@...adcom.com>, 
	Jacob Keller <jacob.e.keller@...el.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v13 01/19] psp: add documentation

On Tue, Sep 16, 2025 at 5:09 PM Daniel Zahka <daniel.zahka@...il.com> wrote:
>
> From: Jakub Kicinski <kuba@...nel.org>
>
> Add documentation of things which belong in the docs rather
> than commit messages.
>
> Reviewed-by: Willem de Bruijn <willemb@...gle.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Daniel Zahka <daniel.zahka@...il.com>
> ---


Reviewed-by: Eric Dumazet <edumazet@...gle.com>

> +Key rotation
> +------------
> +
> +The device key known only to the receiver is fundamental to the design.
> +Per specification this state cannot be directly accessible (it must be
> +impossible to read it out of the hardware of the receiver NIC).
> +Moreover, it has to be "rotated" periodically (usually daily). Rotation
> +means that new device key gets generated (by a random number generator
> +of the device), and used for all new connections. To avoid disrupting
> +old connections the old device key remains in the NIC. A phase bit
> +carried in the packet headers indicates which generation of device key
> +the packet has been encrypted with.

'phase big carried in the packet headers' here refers to a bit
provided by the receiver NIC,
part of the RX descriptor I suppose ?

'packet headers'  is usually applied to Ethernet + network + TCP headers.