netdev - Re: [PATCH net-next] wan: framer: pef2256: use %pe in print format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250918160834.47f746b9@bootlin.com>
Date: Thu, 18 Sep 2025 16:08:34 +0200
From: Herve Codina <herve.codina@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org
Subject: Re: [PATCH net-next] wan: framer: pef2256: use %pe in print format

Hi Jakub,

On Thu, 18 Sep 2025 06:46:37 -0700
Jakub Kicinski <kuba@...nel.org> wrote:

> New cocci check complains:
> 
>   drivers/net/wan/framer/pef2256/pef2256.c:733:3-10: WARNING: Consider using %pe to print PTR_ERR()
> 
> Link: https://lore.kernel.org/1758192227-701925-1-git-send-email-tariqt@nvidia.com
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: herve.codina@...tlin.com
> ---
>  drivers/net/wan/framer/pef2256/pef2256.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wan/framer/pef2256/pef2256.c b/drivers/net/wan/framer/pef2256/pef2256.c
> index 1e4c8e85d598..2a25cbd3f13b 100644
> --- a/drivers/net/wan/framer/pef2256/pef2256.c
> +++ b/drivers/net/wan/framer/pef2256/pef2256.c
> @@ -719,8 +719,8 @@ static int pef2256_probe(struct platform_device *pdev)
>  	pef2256->regmap = devm_regmap_init_mmio(&pdev->dev, iomem,
>  						&pef2256_regmap_config);
>  	if (IS_ERR(pef2256->regmap)) {
> -		dev_err(&pdev->dev, "Failed to initialise Regmap (%ld)\n",
> -			PTR_ERR(pef2256->regmap));
> +		dev_err(&pdev->dev, "Failed to initialise Regmap (%pe)\n",
> +			pef2256->regmap);
>  		return PTR_ERR(pef2256->regmap);
>  	}
>  

Acked-by: Herve Codina <herve.codina@...tlin.com>

Best regards,
Hervé