netdev - Re: [PATCH net-next v3 4/4] net/mlx5e: Report RS-FEC histogram statistics via ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28315831-21f7-49e0-b445-b3df0cb123e0@linux.dev>
Date: Thu, 18 Sep 2025 15:32:51 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>, Michael Chan <michael.chan@...adcom.com>,
 Pavan Chebbi <pavan.chebbi@...adcom.com>, Tariq Toukan <tariqt@...dia.com>,
 Gal Pressman <gal@...dia.com>, intel-wired-lan@...ts.osuosl.org,
 Donald Hunter <donald.hunter@...il.com>, Carolina Jubran
 <cjubran@...dia.com>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
 Yael Chemla <ychemla@...dia.com>, Dragos Tatulea <dtatulea@...dia.com>
Subject: Re: [PATCH net-next v3 4/4] net/mlx5e: Report RS-FEC histogram
 statistics via ethtool

On 18/09/2025 01:48, Jakub Kicinski wrote:
> On Tue, 16 Sep 2025 19:12:57 +0000 Vadim Fedorenko wrote:
>> +	for (int i = 0; i < num_of_bins; i++) {
> 
> brackets unnecessary
> 
> in the other patch you picked u8 for i, good to be consistent
> (int is better)
> 
>> +		hist->values[i].bin_value = MLX5_GET64(rs_histogram_cntrs,
>> +						       rs_histogram_cntrs,
>> +						       hist[i]);
> 
> could also be written as:
> 
> 		hist->values[i].bin_value =
> 			MLX5_GET64(rs_histogram_cntrs, rs_histogram_cntrs, hist[i]);

this doesn't actually fit into 80 chars (84 chars long)... unless we are
not too strict in the drivers..