netdev - Re: [PATCH net-next] net: ti: icssm-prueth: unwind cleanly in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250918162756.GA394836@horms.kernel.org>
Date: Thu, 18 Sep 2025 17:27:56 +0100
From: Simon Horman <horms@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Roger Quadros <rogerq@...com>, MD Danish Anwar <danishanwar@...com>,
	Parvathi Pudi <parvathi@...thit.com>,
	Roger Quadros <rogerq@...nel.org>,
	Mohan Reddy Putluru <pmohan@...thit.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Basharath Hussain Khaja <basharath@...thit.com>,
	"Andrew F. Davis" <afd@...com>,
	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: ti: icssm-prueth: unwind cleanly in probe()

On Thu, Sep 18, 2025 at 12:48:26PM +0300, Dan Carpenter wrote:
> This error handling triggers a Smatch warning:
> 
>     drivers/net/ethernet/ti/icssm/icssm_prueth.c:1574 icssm_prueth_probe()
>     warn: 'prueth->pru1' is an error pointer or valid
> 
> The warning is harmless because the pru_rproc_put() function has an
> IS_ERR_OR_NULL() check built in.  However, there is a small bug if
> syscon_regmap_lookup_by_phandle() fails.  In that case we should call
> of_node_put() on eth0_node and eth1_node.
> 
> It's a little bit easier to re-write this code to only free things which
> we know have been allocated successfully.
> 
> Fixes: 511f6c1ae093 ("net: ti: icssm-prueth: Adds ICSSM Ethernet driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Thanks Dan.

I'm pretty sure I reviewed this code at some point.
Sorry for not noticing this problem then.

Reviewed-by: Simon Horman <horms@...nel.org>

...