[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <014711f8-2d63-4ba7-9c95-89b171476172@gmail.com>
Date: Thu, 18 Sep 2025 07:43:45 +0200
From: Heiner Kallweit <hkallweit1@...il.com>
To: ChunHao Lin <hau@...ltek.com>, nic_swsd@...ltek.com,
andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] r8169: set EEE speed down ratio to 1
On 9/18/2025 4:34 AM, ChunHao Lin wrote:
> EEE speed down means speed down MAC MCU clock. It is not from spec.
> It is kind of Realtek specific power saving feature. But enable it
> may cause some issues, like packet drop or interrupt loss. Different
> hardware may have different issues.
>
> EEE speed down ratio (mac ocp 0xe056[7:4]) is used to set EEE speed
> down rate. The larger this value is, the more power can save. But it
> actually save less power then we expected. And, as mentioned above,
> will impact compatibility. So set it to 1 (mac ocp 0xe056[7:4] = 0)
> , which means not to speed down, to improve compatibility.
>
> Signed-off-by: ChunHao Lin <hau@...ltek.com>
> ---
> v1 -> v2: update commit message
>
Reviewed-by: Heiner Kallweit <hkallweit1@...il.com>
Powered by blists - more mailing lists