[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250918160942.3dc54e9a@kernel.org>
Date: Thu, 18 Sep 2025 16:09:42 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc: <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>,
<davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
<richardcochran@...il.com>, <vladimir.oltean@....com>,
<vadim.fedorenko@...ux.dev>, <rmk+kernel@...linux.org.uk>,
<christophe.jaillet@...adoo.fr>, <rosenp@...il.com>,
<steen.hegelund@...rochip.com>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v2] phy: mscc: Fix PTP for vsc8574 and VSC8572
On Wed, 17 Sep 2025 13:33:16 +0200 Horatiu Vultur wrote:
> When trying to enable PTP on vsc8574 and vsc8572 it is not working even
> if the function vsc8584_ptp_init it says that it has support for PHY
> timestamping. It is not working because there is no PTP device.
> So, to fix this make sure to create a PTP device also for this PHYs as
> they have the same PTP IP as the other vsc PHYs.
May be useful to proof read your commit message, or run it thru
a grammar checker. Copy & paste into a Google Doc would be enough..
Regarding the patch the new function looks like a spitting image
of vsc8584_probe(), minus the revision check.
--
pw-bot: cr
Powered by blists - more mailing lists