netdev - RE: [Intel-wired-lan] [PATCH iwl-net 1/8] i40e: add validation for ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB898522694BCED623B846187B8F16A@IA3PR11MB8985.namprd11.prod.outlook.com>
Date: Thu, 18 Sep 2025 09:02:30 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Simon Horman <horms@...nel.org>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, Greg KH <gregkh@...uxfoundation.org>, "Kyle,
 Jeremiah" <jeremiah.kyle@...el.com>, "Pepiak, Leszek"
	<leszek.pepiak@...el.com>, "Czapnik, Lukasz" <lukasz.czapnik@...el.com>,
	"Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net 1/8] i40e: add validation for
 ring_len param

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Simon Horman
> Sent: Tuesday, August 26, 2025 6:35 PM
> To: Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; netdev@...r.kernel.org; Greg KH
> <gregkh@...uxfoundation.org>; Kyle, Jeremiah <jeremiah.kyle@...el.com>;
> Pepiak, Leszek <leszek.pepiak@...el.com>; Czapnik, Lukasz
> <lukasz.czapnik@...el.com>; Loktionov, Aleksandr
> <aleksandr.loktionov@...el.com>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net 1/8] i40e: add validation for
> ring_len param
> 
> On Wed, Aug 13, 2025 at 12:45:11PM +0200, Przemek Kitszel wrote:
> > From: Lukasz Czapnik <lukasz.czapnik@...el.com>
> >
> > The `ring_len` parameter provided by the virtual function (VF) is
> > assigned directly to the hardware memory context (HMC) without any
> > validation.
> >
> > To address this, introduce an upper boundary check for both Tx and Rx
> > queue lengths. The maximum number of descriptors supported by the
> > hardware is 8k-32.
> > Additionally, enforce alignment constraints: Tx rings must be a
> > multiple of 8, and Rx rings must be a multiple of 32.
> >
> > Fixes: 5c3c48ac6bf5 ("i40e: implement virtual device interface")
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Lukasz Czapnik <lukasz.czapnik@...el.com>
> > Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> > Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> 
> Reviewed-by: Simon Horman <horms@...nel.org>

Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>