netdev - RE: [Intel-wired-lan] [PATCH iwl-net 7/8] i40e: add mask to apply valid bits for itr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB89854C1F24FFDC4F1CBA4F588F16A@IA3PR11MB8985.namprd11.prod.outlook.com>
Date: Thu, 18 Sep 2025 09:04:19 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, Simon Horman
	<horms@...nel.org>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, Greg KH <gregkh@...uxfoundation.org>, "Kyle,
 Jeremiah" <jeremiah.kyle@...el.com>, "Pepiak, Leszek"
	<leszek.pepiak@...el.com>, "Czapnik, Lukasz" <lukasz.czapnik@...el.com>,
	"Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net 7/8] i40e: add mask to apply
 valid bits for itr_idx

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Przemek Kitszel
> Sent: Tuesday, August 26, 2025 9:56 PM
> To: Simon Horman <horms@...nel.org>
> Cc: intel-wired-lan@...ts.osuosl.org; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; netdev@...r.kernel.org; Greg KH
> <gregkh@...uxfoundation.org>; Kyle, Jeremiah <jeremiah.kyle@...el.com>;
> Pepiak, Leszek <leszek.pepiak@...el.com>; Czapnik, Lukasz
> <lukasz.czapnik@...el.com>; Loktionov, Aleksandr
> <aleksandr.loktionov@...el.com>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net 7/8] i40e: add mask to apply
> valid bits for itr_idx
> 
> On 8/26/25 18:34, Simon Horman wrote:
> > On Wed, Aug 13, 2025 at 12:45:17PM +0200, Przemek Kitszel wrote:
> >> From: Lukasz Czapnik <lukasz.czapnik@...el.com>
> >>
> >> The ITR index (itr_idx) is only 2 bits wide. When constructing the
> >> register value for QINT_RQCTL, all fields are ORed together. Without
> >> masking, higher bits from itr_idx may overwrite adjacent fields in
> >> the register.
> >>
> >> Apply I40E_QINT_RQCTL_ITR_INDX_MASK to ensure only the intended bits
> >> are set.
> >
> > I'm all for using FIELD_PREP.
> > But can this actually occur?
> >
> > If not, it feels more like a clean-up.
> 
> I don't see any other place that we validate VF-provided ::rxitr_idx and
> ::txitr_idx of struct virtchnl_vector_map. So it's up to rogue VF.
> With that, I would like to keep this as a fix.
> 
> > Which could be more universally applied.
> 
> this is also true, we typically apply such conversions when doing other work
> that is related (so this time it kind of triggers :))
> 
> > And targeted at net-next (without a Fixes tag).
> >
> >>
> >> Fixes: 5c3c48ac6bf5 ("i40e: implement virtual device interface")
> >> Cc: stable@...r.kernel.org
> >> Signed-off-by: Lukasz Czapnik <lukasz.czapnik@...el.com>
> >> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> >> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> >
> > My question about the target-tree aside, this looks good to me.
> >
> > Reviewed-by: Simon Horman <horms@...nel.org>
> >
> 
> thank you for looking into this series


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>