netdev - Re: [PATCH net-next] net: ti: icssm-prueth: unwind cleanly in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1112336225.391532.1758299205136.JavaMail.zimbra@couthit.local>
Date: Fri, 19 Sep 2025 21:56:45 +0530 (IST)
From: Parvathi Pudi <parvathi@...thit.com>
To: kuba <kuba@...nel.org>, Dan Carpenter <dan.carpenter@...aro.org>
Cc: rogerq <rogerq@...com>, danishanwar <danishanwar@...com>, 
	parvathi <parvathi@...thit.com>, rogerq <rogerq@...nel.org>, 
	pmohan <pmohan@...thit.com>, andrew+netdev <andrew+netdev@...n.ch>, 
	davem <davem@...emloft.net>, edumazet <edumazet@...gle.com>, 
	pabeni <pabeni@...hat.com>, basharath <basharath@...thit.com>, 
	afd <afd@...com>, 
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, 
	netdev <netdev@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: ti: icssm-prueth: unwind cleanly in
 probe()

Hi,

> On Thu, 18 Sep 2025 12:48:26 +0300 Dan Carpenter wrote:
>> This error handling triggers a Smatch warning:
>> 
>>     drivers/net/ethernet/ti/icssm/icssm_prueth.c:1574 icssm_prueth_probe()
>>     warn: 'prueth->pru1' is an error pointer or valid
>> 
>> The warning is harmless because the pru_rproc_put() function has an
>> IS_ERR_OR_NULL() check built in.  However, there is a small bug if
>> syscon_regmap_lookup_by_phandle() fails.  In that case we should call
>> of_node_put() on eth0_node and eth1_node.
>> 
>> It's a little bit easier to re-write this code to only free things which
>> we know have been allocated successfully.
> 
> icssm maintainers - please review

Yes you are correct. This got missed somehow sorry about that.

Now the error return is gracefully exiting by freeing the resources.

Reviewed-by: Parvathi Pudi <parvathi@...thit.com>


Thanks and Regards,
Parvathi.