netdev - Re: [PATCH v2 4/5] can: esd_usb: Rework display of error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250919-dugong-of-pleasurable-courtesy-c4abeb-mkl@pengutronix.de>
Date: Fri, 19 Sep 2025 20:02:36 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Stefan Mätje <stefan.maetje@....eu>
Cc: Vincent Mailhol <mailhol@...nel.org>, 
	Frank Jungclaus <frank.jungclaus@....eu>, linux-can@...r.kernel.org, socketcan@....eu, 
	Simon Horman <horms@...nel.org>, Oliver Hartkopp <socketcan@...tkopp.net>, 
	Wolfgang Grandegger <wg@...ndegger.com>, "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 4/5] can: esd_usb: Rework display of error messages

On 21.08.2025 16:34:21, Stefan Mätje wrote:
> - esd_usb_open(): Get rid of duplicate "couldn't start device: %d\n"
>   message already printed from esd_usb_start().
> - Fix duplicate printout of network device name when network device
>   is registered. Add an unregister message for the network device
>   as counterpart to the register message.
> - Added the printout of error codes together with the error messages
>   in esd_usb_close() and some in esd_usb_probe(). The additional error
>   codes should lead to a better understanding what is really going
>   wrong.
> - Convert all occurrences of error status prints to use "ERR_PTR(err)"
>   instead of printing the decimal value of "err".
> - Rename retval to err in esd_usb_read_bulk_callback() to make the
>   naming of error status variables consistent with all other functions.
> 
> Signed-off-by: Stefan Mätje <stefan.maetje@....eu>

I've squashed the changes in the probe function into patch 1.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)