netdev - Re: [PATCH bpf-next v2 2/4] net/smc: bpf: Introduce generic hook for handshake flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202509191742.19csfvEU-lkp@intel.com>
Date: Fri, 19 Sep 2025 17:25:28 +0800
From: kernel test robot <lkp@...el.com>
To: "D. Wythe" <alibuda@...ux.alibaba.com>, ast@...nel.org,
	daniel@...earbox.net, andrii@...nel.org, martin.lau@...ux.dev,
	pabeni@...hat.com, song@...nel.org, sdf@...gle.com,
	haoluo@...gle.com, yhs@...com, edumazet@...gle.com,
	john.fastabend@...il.com, kpsingh@...nel.org, jolsa@...nel.org,
	mjambigi@...ux.ibm.com, wenjia@...ux.ibm.com, wintera@...ux.ibm.com,
	dust.li@...ux.alibaba.com, tonylu@...ux.alibaba.com,
	guwen@...ux.alibaba.com
Cc: oe-kbuild-all@...ts.linux.dev, bpf@...r.kernel.org, davem@...emloft.net,
	kuba@...nel.org, netdev@...r.kernel.org, sidraya@...ux.ibm.com,
	jaka@...ux.ibm.com
Subject: Re: [PATCH bpf-next v2 2/4] net/smc: bpf: Introduce generic hook for
 handshake flow

Hi Wythe,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/D-Wythe/bpf-export-necessary-symbols-for-modules-with-struct_ops/20250918-160530
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20250918080342.25041-3-alibuda%40linux.alibaba.com
patch subject: [PATCH bpf-next v2 2/4] net/smc: bpf: Introduce generic hook for handshake flow
config: i386-randconfig-063-20250919 (https://download.01.org/0day-ci/archive/20250919/202509191742.19csfvEU-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250919/202509191742.19csfvEU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509191742.19csfvEU-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> net/ipv4/tcp_output.c:776:33: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct smc_hs_ctrl *ctrl @@     got struct smc_hs_ctrl [noderef] __rcu * @@
   net/ipv4/tcp_output.c:776:33: sparse:     expected struct smc_hs_ctrl *ctrl
   net/ipv4/tcp_output.c:776:33: sparse:     got struct smc_hs_ctrl [noderef] __rcu *
   net/ipv4/tcp_output.c:796:34: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct smc_hs_ctrl *ctrl @@     got struct smc_hs_ctrl [noderef] __rcu * @@
   net/ipv4/tcp_output.c:796:34: sparse:     expected struct smc_hs_ctrl *ctrl
   net/ipv4/tcp_output.c:796:34: sparse:     got struct smc_hs_ctrl [noderef] __rcu *
--
>> net/smc/smc_sysctl.c:59:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct smc_hs_ctrl [noderef] __rcu *__ret @@     got struct smc_hs_ctrl *[assigned] ctrl @@
   net/smc/smc_sysctl.c:59:16: sparse:     expected struct smc_hs_ctrl [noderef] __rcu *__ret
   net/smc/smc_sysctl.c:59:16: sparse:     got struct smc_hs_ctrl *[assigned] ctrl
>> net/smc/smc_sysctl.c:59:14: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct smc_hs_ctrl *[assigned] ctrl @@     got struct smc_hs_ctrl [noderef] __rcu *[assigned] __ret @@
   net/smc/smc_sysctl.c:59:14: sparse:     expected struct smc_hs_ctrl *[assigned] ctrl
   net/smc/smc_sysctl.c:59:14: sparse:     got struct smc_hs_ctrl [noderef] __rcu *[assigned] __ret

vim +776 net/ipv4/tcp_output.c

   767	
   768	static void smc_set_option(struct tcp_sock *tp,
   769				   struct tcp_out_options *opts,
   770				   unsigned int *remaining)
   771	{
   772	#if IS_ENABLED(CONFIG_SMC)
   773		struct sock *sk = &tp->inet_conn.icsk_inet.sk;
   774	
   775		if (static_branch_unlikely(&tcp_have_smc) && tp->syn_smc) {
 > 776			tp->syn_smc = !!smc_call_hsbpf(1, sk, syn_option, tp);
   777			/* re-check syn_smc */
   778			if (tp->syn_smc &&
   779			    *remaining >= TCPOLEN_EXP_SMC_BASE_ALIGNED) {
   780				opts->options |= OPTION_SMC;
   781				*remaining -= TCPOLEN_EXP_SMC_BASE_ALIGNED;
   782			}
   783		}
   784	#endif
   785	}
   786	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki