[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7267ac9c-bc6b-4f1d-a16b-e86f0566421d@bootlin.com>
Date: Sun, 21 Sep 2025 13:48:14 +0530
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 05/10] net: stmmac: socfpga: convert to use
phy_interface
Hi Russell,
On 17/09/2025 20:42, Russell King (Oracle) wrote:
> dwmac-socfpga uses MII, RMII, GMII, RGMII, SGMII and 1000BASE-X
> interface modes, and supports the Lynx PCS. The Lynx PCS will only be
> used for SGMII and 1000BASE-X modes, with the MAC programmed to use
> GMII or MII mode to talk to the PCS. This suggests that the Synopsys
> optional dwmac PCS is not present.
>
> None of the DTS files set "mac-mode", so mac_interface will be
> identical to phy_interface.
>
> Convert dwmac-socfpga to use phy_interface when determining the
> interface mode rather than mac_interface.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
I know this has been merged, but FWIW this looks good to me. sorry for
not having had time to test this or the Marvell PTP stuff lately, I'm
juggling between too many work and non-work related things and barely
have time to work on phy_port :(
Thanks for this cleanup,
Maxime
Powered by blists - more mailing lists