netdev - Re: [PATCH net v2 0/2] Fix generating skb from non-linear xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0eb722b9-bad9-43b4-a8a7-6f91f926e9f5@gmail.com>
Date: Sun, 21 Sep 2025 14:24:53 +0300
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Amery Hung <ameryhung@...il.com>, netdev@...r.kernel.org
Cc: bpf@...r.kernel.org, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, kuba@...nel.org,
 martin.lau@...nel.org, noren@...dia.com, dtatulea@...dia.com,
 saeedm@...dia.com, tariqt@...dia.com, mbloch@...dia.com, cpaasch@...nai.com,
 kernel-team@...a.com
Subject: Re: [PATCH net v2 0/2] Fix generating skb from non-linear xdp_buff
 for mlx5



On 16/09/2025 16:52, Tariq Toukan wrote:
> 
> 
> On 16/09/2025 1:58, Amery Hung wrote:
>> v1 -> v2
>>    - Simplify truesize calculation (Tariq)
>>    - Narrow the scope of local variables (Tariq)
>>    - Make truesize adjustment conditional (Tariq)
>>
>> v1
>>    - Separate the set from [0] (Dragos)
>>    - Split legacy RQ and striding RQ fixes (Dragos)
>>    - Drop conditional truesize and end frag ptr update (Dragos)
>>    - Fix truesize calculation in striding RQ (Dragos)
>>    - Fix the always zero headlen passed to __pskb_pull_tail() that
>>      causes kernel panic (Nimrod)
>>
>>    Link: https://lore.kernel.org/bpf/20250910034103.650342-1- 
>> ameryhung@...il.com/
>>
>> ---
>>
>> Hi all,
>>
>> This patchset, separated from [0], contains fixes to mlx5 when handling
>> non-linear xdp_buff. The driver currently generates skb based on
>> information obtained before the XDP program runs, such as the number of
>> fragments and the size of the linear data. However, the XDP program can
>> actually change them through bpf_adjust_{head,tail}(). Fix the bugs
>> bygenerating skb according to xdp_buff after the XDP program runs.
>>
>> [0] https://lore.kernel.org/bpf/20250905173352.3759457-1- 
>> ameryhung@...il.com/
>>
>> ---
>>
>> Amery Hung (2):
>>    net/mlx5e: RX, Fix generating skb from non-linear xdp_buff for legacy
>>      RQ
>>    net/mlx5e: RX, Fix generating skb from non-linear xdp_buff for
>>      striding RQ
>>
>>   .../net/ethernet/mellanox/mlx5/core/en_rx.c   | 47 +++++++++++++++----
>>   1 file changed, 38 insertions(+), 9 deletions(-)
>>
> 
> Thanks for your patches.
> They LGTM.
> 
> As these are touching a sensitive area, I am taking them into internal 
> functional and perf testing.
> I'll update with results once completed.
> 

Initial testing passed.
Thanks for your patches.

Reviewed-by: Tariq Toukan <tariqt@...dia.com>