netdev - Re: [PATCH net 3/3] selftests: fib_nexthops: Add test cases for FDB status change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7b10e85-1201-4865-84c4-17e2d0971ac9@kernel.org>
Date: Sun, 21 Sep 2025 09:39:29 -0600
From: David Ahern <dsahern@...nel.org>
To: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, horms@...nel.org, petrm@...dia.com, aroulin@...dia.com
Subject: Re: [PATCH net 3/3] selftests: fib_nexthops: Add test cases for FDB
 status change

On 9/21/25 9:08 AM, Ido Schimmel wrote:
> Add the following test cases for both IPv4 and IPv6:
> 
> * Can change from FDB nexthop to non-FDB nexthop and vice versa.
> * Can change FDB nexthop address while in a group.
> * Cannot change from FDB nexthop to non-FDB nexthop and vice versa while
>   in a group.
> 
> Output without "nexthop: Forbid FDB status change while nexthop is in a
> group":
> 
>  # ./fib_nexthops.sh -t "ipv6_fdb_grp_fcnal ipv4_fdb_grp_fcnal"
> 
>  IPv6 fdb groups functional
>  --------------------------
>  [...]
>  TEST: Replace FDB nexthop to non-FDB nexthop                        [ OK ]
>  TEST: Replace non-FDB nexthop to FDB nexthop                        [ OK ]
>  TEST: Replace FDB nexthop address while in a group                  [ OK ]
>  TEST: Replace FDB nexthop to non-FDB nexthop while in a group       [FAIL]
>  TEST: Replace non-FDB nexthop to FDB nexthop while in a group       [FAIL]
>  [...]
> 
>  IPv4 fdb groups functional
>  --------------------------
>  [...]
>  TEST: Replace FDB nexthop to non-FDB nexthop                        [ OK ]
>  TEST: Replace non-FDB nexthop to FDB nexthop                        [ OK ]
>  TEST: Replace FDB nexthop address while in a group                  [ OK ]
>  TEST: Replace FDB nexthop to non-FDB nexthop while in a group       [FAIL]
>  TEST: Replace non-FDB nexthop to FDB nexthop while in a group       [FAIL]
>  [...]
> 
>  Tests passed:  36
>  Tests failed:   4
>  Tests skipped:  0
> 
> Output with "nexthop: Forbid FDB status change while nexthop is in a
> group":
> 
>  # ./fib_nexthops.sh -t "ipv6_fdb_grp_fcnal ipv4_fdb_grp_fcnal"
> 
>  IPv6 fdb groups functional
>  --------------------------
>  [...]
>  TEST: Replace FDB nexthop to non-FDB nexthop                        [ OK ]
>  TEST: Replace non-FDB nexthop to FDB nexthop                        [ OK ]
>  TEST: Replace FDB nexthop address while in a group                  [ OK ]
>  TEST: Replace FDB nexthop to non-FDB nexthop while in a group       [ OK ]
>  TEST: Replace non-FDB nexthop to FDB nexthop while in a group       [ OK ]
>  [...]
> 
>  IPv4 fdb groups functional
>  --------------------------
>  [...]
>  TEST: Replace FDB nexthop to non-FDB nexthop                        [ OK ]
>  TEST: Replace non-FDB nexthop to FDB nexthop                        [ OK ]
>  TEST: Replace FDB nexthop address while in a group                  [ OK ]
>  TEST: Replace FDB nexthop to non-FDB nexthop while in a group       [ OK ]
>  TEST: Replace non-FDB nexthop to FDB nexthop while in a group       [ OK ]
>  [...]
> 
>  Tests passed:  40
>  Tests failed:   0
>  Tests skipped:  0
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  tools/testing/selftests/net/fib_nexthops.sh | 40 +++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>