netdev - Re: [HSR] hsr_ping test failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250921193356.rCL4R8lo@linutronix.de>
Date: Sun, 21 Sep 2025 21:33:56 +0200
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: Yunshui Jiang <jiangyunshui@...inos.cn>,
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Lukasz Majewski <lukma@...x.de>, Geliang Tang <geliang@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [HSR] hsr_ping test failed

On 2025-09-12 03:04:36 [+0000], Hangbin Liu wrote:
> Hi, Sebastian, Yunshui,
Hi,

> I tried to run hsr_ping recently on x86_64 arch (build via vng --build
> --config tools/testing/selftests/net/hsr/config, latest net branch,
> iproute2-6.15.0) and the test always failed due to error
> "Expect to send and receive 10 packets and no duplicates."
> 
> I checked the normal ping test and found it also has duplicates.
> e.g.
> 
> PING 100.64.0.3 (100.64.0.3) 56(84) bytes of data.

Something is broken. I traced it down to commit
	9cfb5e7f0ded2 ("net: hsr: fix hsr_init_sk() vs network/transport headers.")

haven't put much into it but appears that skb_reset_network_header() is
expected to be initialized "late" which leads to the large mac-len.

Sebastian