| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJaqyWcGLKoa0mWivac5BfBTJbyAnW14FvAmA0EteunidMc6NQ@mail.gmail.com>
Date: Mon, 22 Sep 2025 08:02:13 +0200
From: Eugenio Perez Martin <eperezma@...hat.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: kernel test robot <lkp@...el.com>, llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
kvm@...r.kernel.org, virtualization@...ts.linux-foundation.org,
netdev@...r.kernel.org
Subject: Re: [mst-vhost:vhost 41/44] drivers/vdpa/pds/vdpa_dev.c:590:19:
error: incompatible function pointer types initializing 's64 (*)(struct
vdpa_device *, u16)' (aka 'long long (*)(struct vdpa_device *, unsigned
short)') with an expression of type 'u32 (struct vdpa_device *, u16)' (aka ...
On Sun, Sep 21, 2025 at 11:31 PM Michael S. Tsirkin <mst@...hat.com> wrote:
>
> On Sat, Sep 20, 2025 at 10:41:40PM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
> > head: 877102ca14b3ee9b5343d71f6420f036baf8a9fc
> > commit: 2951c77700c3944ecd991ede7ee77e31f47f24ab [41/44] vduse: add vq group support
> > config: loongarch-randconfig-001-20250920 (https://download.01.org/0day-ci/archive/20250920/202509202256.zVt4MifB-lkp@intel.com/config)
> > compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 7c861bcedf61607b6c087380ac711eb7ff918ca6)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250920/202509202256.zVt4MifB-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@...el.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202509202256.zVt4MifB-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> > >> drivers/vdpa/pds/vdpa_dev.c:590:19: error: incompatible function pointer types initializing 's64 (*)(struct vdpa_device *, u16)' (aka 'long long (*)(struct vdpa_device *, unsigned short)') with an expression of type 'u32 (struct vdpa_device *, u16)' (aka 'unsigned int (struct vdpa_device *, unsigned short)') [-Wincompatible-function-pointer-types]
> > 590 | .get_vq_group = pds_vdpa_get_vq_group,
> > | ^~~~~~~~~~~~~~~~~~~~~
> > 1 error generated.
> >
>
> Eugenio, just making sure you see this. I can not merge patches that
> break build.
>
Absolutely, I forgot to enable all the vdpa drivers in my test. Silly
mistake, fixing it right now. Thanks!
> > vim +590 drivers/vdpa/pds/vdpa_dev.c
> >
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 577
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 578 static const struct vdpa_config_ops pds_vdpa_ops = {
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 579 .set_vq_address = pds_vdpa_set_vq_address,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 580 .set_vq_num = pds_vdpa_set_vq_num,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 581 .kick_vq = pds_vdpa_kick_vq,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 582 .set_vq_cb = pds_vdpa_set_vq_cb,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 583 .set_vq_ready = pds_vdpa_set_vq_ready,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 584 .get_vq_ready = pds_vdpa_get_vq_ready,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 585 .set_vq_state = pds_vdpa_set_vq_state,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 586 .get_vq_state = pds_vdpa_get_vq_state,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 587 .get_vq_notification = pds_vdpa_get_vq_notification,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 588 .get_vq_irq = pds_vdpa_get_vq_irq,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 589 .get_vq_align = pds_vdpa_get_vq_align,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 @590 .get_vq_group = pds_vdpa_get_vq_group,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 591
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 592 .get_device_features = pds_vdpa_get_device_features,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 593 .set_driver_features = pds_vdpa_set_driver_features,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 594 .get_driver_features = pds_vdpa_get_driver_features,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 595 .set_config_cb = pds_vdpa_set_config_cb,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 596 .get_vq_num_max = pds_vdpa_get_vq_num_max,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 597 .get_device_id = pds_vdpa_get_device_id,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 598 .get_vendor_id = pds_vdpa_get_vendor_id,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 599 .get_status = pds_vdpa_get_status,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 600 .set_status = pds_vdpa_set_status,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 601 .reset = pds_vdpa_reset,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 602 .get_config_size = pds_vdpa_get_config_size,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 603 .get_config = pds_vdpa_get_config,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 604 .set_config = pds_vdpa_set_config,
> > 151cc834f3ddafe Shannon Nelson 2023-05-19 605 };
> > 25d1270b6e9ea89 Shannon Nelson 2023-05-19 606 static struct virtio_device_id pds_vdpa_id_table[] = {
> > 25d1270b6e9ea89 Shannon Nelson 2023-05-19 607 {VIRTIO_ID_NET, VIRTIO_DEV_ANY_ID},
> > 25d1270b6e9ea89 Shannon Nelson 2023-05-19 608 {0},
> > 25d1270b6e9ea89 Shannon Nelson 2023-05-19 609 };
> > 25d1270b6e9ea89 Shannon Nelson 2023-05-19 610
> >
> > :::::: The code at line 590 was first introduced by commit
> > :::::: 151cc834f3ddafec869269fe48036460d920d08a pds_vdpa: add support for vdpa and vdpamgmt interfaces
> >
> > :::::: TO: Shannon Nelson <shannon.nelson@....com>
> > :::::: CC: Michael S. Tsirkin <mst@...hat.com>
> >
> > --
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
>
Powered by blists - more mailing lists