netdev - Re: [PATCH net-next 1/2] net: phy: dp83640: improve phydev and driver removal handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c07c2263-3276-4c9c-a0c0-7a8c9580a4cf@bootlin.com>
Date: Mon, 22 Sep 2025 21:17:32 +0530
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Heiner Kallweit <hkallweit1@...il.com>, Andrew Lunn <andrew@...n.ch>,
 Andrew Lunn <andrew+netdev@...n.ch>,
 Russell King - ARM Linux <linux@...linux.org.uk>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>, David Miller <davem@...emloft.net>,
 Richard Cochran <richardcochran@...il.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: phy: dp83640: improve phydev and driver
 removal handling

Hi Heiner,

On 21/09/2025 03:03, Heiner Kallweit wrote:
> Once the last user of a clock has been removed, the clock should be
> removed. So far orphaned clocks are cleaned up in dp83640_free_clocks()
> only. Add the logic to remove orphaned clocks in dp83640_remove().
> This allows to simplify the code, and use standard macro
> module_phy_driver(). dp83640 was the last external user of
> phy_driver_register(), so we can stop exporting this function afterwards.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Nice simplification ! I've scratched away the small amount of hair left 
on my head reading this, and your changes look correct to me :)

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Maxime