netdev - Re: [PATCH net-next 11/20] xsk: Add small helper xp_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d05079d-7cbc-4f94-9068-4db30e55aa42@iogearbox.net>
Date: Mon, 22 Sep 2025 18:17:47 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, kuba@...nel.org,
 davem@...emloft.net, razor@...ckwall.org, pabeni@...hat.com,
 willemb@...gle.com, sdf@...ichev.me, john.fastabend@...il.com,
 martin.lau@...nel.org, jordan@...fe.io, magnus.karlsson@...el.com,
 David Wei <dw@...idwei.uk>
Subject: Re: [PATCH net-next 11/20] xsk: Add small helper xp_pool_bindable

On 9/22/25 6:03 PM, Maciej Fijalkowski wrote:
> On Fri, Sep 19, 2025 at 11:31:44PM +0200, Daniel Borkmann wrote:
>> Add another small helper called xp_pool_bindable and move the current
>> dev_get_min_mp_channel_count test into this helper. Pass in the pool
>> object, such that we derive the netdev from the prior registered pool.
>>
>> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
>> Co-developed-by: David Wei <dw@...idwei.uk>
>> Signed-off-by: David Wei <dw@...idwei.uk>
>> ---
>>   net/xdp/xsk_buff_pool.c | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/net/xdp/xsk_buff_pool.c b/net/xdp/xsk_buff_pool.c
>> index 375696f895d4..d2109d683fe5 100644
>> --- a/net/xdp/xsk_buff_pool.c
>> +++ b/net/xdp/xsk_buff_pool.c
>> @@ -54,6 +54,11 @@ int xp_alloc_tx_descs(struct xsk_buff_pool *pool, struct xdp_sock *xs)
>>   	return 0;
>>   }
>>   
>> +static bool xp_pool_bindable(struct xsk_buff_pool *pool)
>> +{
>> +	return dev_get_min_mp_channel_count(pool->netdev) == 0;
>> +}
> 
> Is this really a must have in this patchset? You don't seem to make use of
> it anywhere.

That is needed given we need to look at the pool's netdev which then is
the one of the phys device.

>>   struct xsk_buff_pool *xp_create_and_assign_umem(struct xdp_sock *xs,
>>   						struct xdp_umem *umem)
>>   {
>> @@ -199,7 +204,7 @@ int xp_assign_dev(struct xsk_buff_pool *pool,
>>   		err = -EOPNOTSUPP;
>>   		goto err_unreg_pool;
>>   	}
>> -	if (dev_get_min_mp_channel_count(netdev)) {
>> +	if (!xp_pool_bindable(pool)) {
>>   		err = -EBUSY;
>>   		goto err_unreg_pool;
>>   	}
>> -- 
>> 2.43.0
>>