netdev - Re: [PATCH net-next] eth: fbnic: Read module EEPROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49d3b51d-5ee0-40a6-b6c4-88f6cea96e8c@gmail.com>
Date: Mon, 22 Sep 2025 09:56:26 -0700
From: Mohsin Bashir <mohsin.bashr@...il.com>
To: Ido Schimmel <idosch@...sch.org>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kuba@...nel.org,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 gustavoars@...nel.org, horms@...nel.org, jacob.e.keller@...el.com,
 kees@...nel.org, kernel-team@...a.com, lee@...ger.us, linux@...linux.org.uk,
 pabeni@...hat.com, sanman.p211993@...il.com, suhui@...china.com,
 vadim.fedorenko@...ux.dev
Subject: Re: [PATCH net-next] eth: fbnic: Read module EEPROM


>> +	if (page_data->bank != 0) {
> 
> What is the reason for this check?
> 
> I understand that it's very unlikely to have a transceiver with banked
> pages connected to this NIC (requires more than 8 lanes), but it's
> generally better to not restrict this ethtool operation unless you have
> a good reason to, especially when the firmware seems to support banked
> pages.
> 
Hi Ido,

Thanks for the review.

The bank field is essentially unused in our common case. We were just 
sending bank 0 to the FW so I believe, we should be okay removing this. 
I'll update this part in V2.

>> +		NL_SET_ERR_MSG_MOD(extack,
>> +				   "Invalid bank. Only 0 is supported");
>> +		return -EINVAL;
>> +	}
>> +
>> +	fw_cmpl = __fbnic_fw_alloc_cmpl(FBNIC_TLV_MSG_ID_QSFP_READ_RESP,
> 
> QSFP is not the most accurate term, but I assume it's named that way to
> be consistent with the HW/FW data sheet.
> 

Yes, as Alex pointed out it is to be consistent with FW.