netdev - Re: [PATCH net 0/2] lantiq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250922113452.07844cd2@kernel.org>
Date: Mon, 22 Sep 2025 11:34:52 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: Daniel Golle <daniel@...rotopia.org>, netdev@...r.kernel.org, Hauke
 Mehrtens <hauke@...ke-m.de>, Andrew Lunn <andrew@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net 0/2] lantiq_gswip fixes

On Mon, 22 Sep 2025 14:07:17 +0300 Vladimir Oltean wrote:
> - I don't think your local_termination.sh exercises the bug fixed by
>   patch "[1/2] net: dsa: lantiq_gswip: move gswip_add_single_port_br()
>   call to port_setup()". The port has to be initially down before
>   joining a bridge, and be brought up afterwards. This can be tested
>   manually. In local_termination.sh, although bridge_create() runs
>   "ip link set $h2 up" after "ip link set $h2 master br0", $h2 was
>   already up due to "simple_if_init $h2".

Waiting for more testing..

> - If the vast majority of users make use of this driver through OpenWrt,
>   and if backporting to the required trees is done by OpenWrt and the
>   fixes' presence in linux-stable is not useful, I can offer to resend
>   this set plus the remaining patches all together through the net-next
>   tree, and avoid complications such as merge conflicts.

FWIW I don't even see a real conflict when merging this. git seems to
be figuring things out on its own.